Bug 92876 - keyring.get_password may raise an exception.
Summary: keyring.get_password may raise an exception.
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: arno.
Depends on:
Reported: 2012-08-01 09:41 PDT by arno.
Modified: 2012-08-01 10:48 PDT (History)
2 users (show)

See Also:

patch proposal (2.11 KB, patch)
2012-08-01 09:46 PDT, arno.
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description arno. 2012-08-01 09:41:01 PDT
when using gnome keyring, the method get_password may raise an IOError exception.

One workaround is to wrap self._keyring.get_password in a try catch.
May be we can also wrap set_password in a try/catch also
Comment 1 arno. 2012-08-01 09:46:27 PDT
Created attachment 155824 [details]
patch proposal

In this patch, I catch all exception, (not IOError only), just to be safe
Comment 2 WebKit Review Bot 2012-08-01 10:48:24 PDT
Comment on attachment 155824 [details]
patch proposal

Clearing flags on attachment: 155824

Committed r124343: <http://trac.webkit.org/changeset/124343>
Comment 3 WebKit Review Bot 2012-08-01 10:48:27 PDT
All reviewed patches have been landed.  Closing bug.