Bug 92869 - Clean-up touchadjustment tests
Summary: Clean-up touchadjustment tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 420+
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Allan Sandfeld Jensen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-01 06:37 PDT by Allan Sandfeld Jensen
Modified: 2012-08-01 11:45 PDT (History)
3 users (show)

See Also:


Attachments
Patch (64.07 KB, patch)
2012-08-01 06:51 PDT, Allan Sandfeld Jensen
no flags Details | Formatted Diff | Diff
Patch (79.15 KB, patch)
2012-08-01 07:37 PDT, Allan Sandfeld Jensen
no flags Details | Formatted Diff | Diff
Patch (80.95 KB, patch)
2012-08-01 09:19 PDT, Allan Sandfeld Jensen
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Allan Sandfeld Jensen 2012-08-01 06:37:58 PDT
There are now several touchadjustment tests, many of them use identical or similar auxilary functions during the test. This code should be gathered in a single central file so they can share code.

Additionally many of the tests do not have proper doctype or contains other minor mistakes, which can be cleaned up, so the tests appear uniform and form a good example for furture touchadjustment tests.
Comment 1 Allan Sandfeld Jensen 2012-08-01 06:51:49 PDT
Created attachment 155801 [details]
Patch
Comment 2 Allan Sandfeld Jensen 2012-08-01 07:37:34 PDT
Created attachment 155808 [details]
Patch

Add the last cleaned up files to the patch
Comment 3 Allan Sandfeld Jensen 2012-08-01 09:19:55 PDT
Created attachment 155819 [details]
Patch

Fix copy-paste error in html-label.html, and put bug-number instead of description in test title
Comment 4 Jocelyn Turcotte 2012-08-01 09:38:52 PDT
Comment on attachment 155819 [details]
Patch

I'm no expert on this but it makes sense, rs=me.
Comment 5 WebKit Review Bot 2012-08-01 11:45:30 PDT
Comment on attachment 155819 [details]
Patch

Clearing flags on attachment: 155819

Committed r124351: <http://trac.webkit.org/changeset/124351>
Comment 6 WebKit Review Bot 2012-08-01 11:45:34 PDT
All reviewed patches have been landed.  Closing bug.