Bug 92866 - MediaStream API: Add RTCPeerConnectionHandler infrastructure
Summary: MediaStream API: Add RTCPeerConnectionHandler infrastructure
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Tommy Widenflycht
URL:
Keywords:
Depends on: 92980
Blocks: 80589
  Show dependency treegraph
 
Reported: 2012-08-01 05:17 PDT by Tommy Widenflycht
Modified: 2012-08-02 08:56 PDT (History)
10 users (show)

See Also:


Attachments
Patch (30.08 KB, patch)
2012-08-01 05:32 PDT, Tommy Widenflycht
no flags Details | Formatted Diff | Diff
Patch (30.06 KB, patch)
2012-08-01 05:39 PDT, Tommy Widenflycht
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from gce-cr-linux-01 (603.81 KB, application/zip)
2012-08-01 06:38 PDT, WebKit Review Bot
no flags Details
Patch (30.16 KB, patch)
2012-08-01 06:51 PDT, Tommy Widenflycht
abarth: review+
Details | Formatted Diff | Diff
Patch for landing (30.06 KB, patch)
2012-08-02 01:57 PDT, Tommy Widenflycht
no flags Details | Formatted Diff | Diff
Patch (29.92 KB, patch)
2012-08-02 06:42 PDT, Tommy Widenflycht
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tommy Widenflycht 2012-08-01 05:17:54 PDT
Introducing RTCPeerConnectionHandler & RTCPeerConnectionHandlerClient, together with the Chromium WebKit interface.
Comment 1 Tommy Widenflycht 2012-08-01 05:32:12 PDT
Created attachment 155787 [details]
Patch
Comment 2 WebKit Review Bot 2012-08-01 05:34:38 PDT
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Comment 3 Tommy Widenflycht 2012-08-01 05:39:47 PDT
Created attachment 155788 [details]
Patch
Comment 4 Tommy Widenflycht 2012-08-01 05:42:03 PDT
The patch is on the large size but most of it is licences, and very little actual code.
Comment 5 WebKit Review Bot 2012-08-01 06:38:09 PDT
Comment on attachment 155788 [details]
Patch

Attachment 155788 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/13403598

New failing tests:
fast/mediastream/RTCPeerConnection.html
Comment 6 WebKit Review Bot 2012-08-01 06:38:15 PDT
Created attachment 155797 [details]
Archive of layout-test-results from gce-cr-linux-01

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: gce-cr-linux-01  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid
Comment 7 Tommy Widenflycht 2012-08-01 06:51:41 PDT
Created attachment 155800 [details]
Patch
Comment 8 Adam Barth 2012-08-01 11:37:39 PDT
Comment on attachment 155800 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=155800&action=review

> Source/Platform/chromium/public/Platform.h:414
> +    // This is an highly experimental feature not yet in the WebRTC standard.

I'd skip this comment.  It's likely to get out of date quickly.
Comment 9 Tommy Widenflycht 2012-08-02 01:57:50 PDT
Created attachment 156008 [details]
Patch for landing
Comment 10 Tommy Widenflycht 2012-08-02 03:11:12 PDT
Comment on attachment 155800 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=155800&action=review

>> Source/Platform/chromium/public/Platform.h:414
>> +    // This is an highly experimental feature not yet in the WebRTC standard.
> 
> I'd skip this comment.  It's likely to get out of date quickly.

Removed.
Comment 11 WebKit Review Bot 2012-08-02 03:13:37 PDT
Comment on attachment 156008 [details]
Patch for landing

Rejecting attachment 156008 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1

ERROR: /mnt/git/webkit-commit-queue/Source/Platform/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://queues.webkit.org/results/13428121
Comment 12 WebKit Review Bot 2012-08-02 04:43:17 PDT
Comment on attachment 156008 [details]
Patch for landing

Clearing flags on attachment: 156008

Committed r124439: <http://trac.webkit.org/changeset/124439>
Comment 13 WebKit Review Bot 2012-08-02 04:43:24 PDT
All reviewed patches have been landed.  Closing bug.
Comment 14 WebKit Review Bot 2012-08-02 05:28:42 PDT
Re-opened since this is blocked by 92980
Comment 15 Tommy Widenflycht 2012-08-02 06:42:01 PDT
Created attachment 156069 [details]
Patch
Comment 16 Tommy Widenflycht 2012-08-02 06:44:04 PDT
Previous patch broke chromium release Mac, due to an unused member variable. This time verified on a Mac.
Comment 17 WebKit Review Bot 2012-08-02 08:56:38 PDT
Comment on attachment 156069 [details]
Patch

Clearing flags on attachment: 156069

Committed r124460: <http://trac.webkit.org/changeset/124460>
Comment 18 WebKit Review Bot 2012-08-02 08:56:45 PDT
All reviewed patches have been landed.  Closing bug.