Introducing RTCPeerConnectionHandler & RTCPeerConnectionHandlerClient, together with the Chromium WebKit interface.
Created attachment 155787 [details] Patch
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Created attachment 155788 [details] Patch
The patch is on the large size but most of it is licences, and very little actual code.
Comment on attachment 155788 [details] Patch Attachment 155788 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13403598 New failing tests: fast/mediastream/RTCPeerConnection.html
Created attachment 155797 [details] Archive of layout-test-results from gce-cr-linux-01 The attached test failures were seen while running run-webkit-tests on the chromium-ews. Bot: gce-cr-linux-01 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid
Created attachment 155800 [details] Patch
Comment on attachment 155800 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=155800&action=review > Source/Platform/chromium/public/Platform.h:414 > + // This is an highly experimental feature not yet in the WebRTC standard. I'd skip this comment. It's likely to get out of date quickly.
Created attachment 156008 [details] Patch for landing
Comment on attachment 155800 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=155800&action=review >> Source/Platform/chromium/public/Platform.h:414 >> + // This is an highly experimental feature not yet in the WebRTC standard. > > I'd skip this comment. It's likely to get out of date quickly. Removed.
Comment on attachment 156008 [details] Patch for landing Rejecting attachment 156008 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 ERROR: /mnt/git/webkit-commit-queue/Source/Platform/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://queues.webkit.org/results/13428121
Comment on attachment 156008 [details] Patch for landing Clearing flags on attachment: 156008 Committed r124439: <http://trac.webkit.org/changeset/124439>
All reviewed patches have been landed. Closing bug.
Re-opened since this is blocked by 92980
Created attachment 156069 [details] Patch
Previous patch broke chromium release Mac, due to an unused member variable. This time verified on a Mac.
Comment on attachment 156069 [details] Patch Clearing flags on attachment: 156069 Committed r124460: <http://trac.webkit.org/changeset/124460>