Bug 92863 - Layout Test fast/forms/input-widths.html is failing
Summary: Layout Test fast/forms/input-widths.html is failing
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: yosin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-01 04:38 PDT by Alexander Pavlov (apavlov)
Modified: 2012-08-02 01:17 PDT (History)
2 users (show)

See Also:

Attachments
Patch 1 (3.78 KB, patch)
2012-08-02 00:30 PDT, yosin 		no flags Details | Formatted Diff | Diff
Patch 2 (4.67 KB, patch)
2012-08-02 00:55 PDT, yosin 		no flags Details | Formatted Diff | Diff
Patch 3 (4.77 KB, patch)
2012-08-02 00:59 PDT, yosin 		no flags Details | Formatted Diff | Diff
Patch 4 (4.79 KB, patch)
2012-08-02 01:01 PDT, yosin 		no flags Details | Formatted Diff | Diff
Patch 5 (4.59 KB, patch)
2012-08-02 01:13 PDT, yosin 		no flags Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Pavlov (apavlov) 2012-08-01 04:38:59 PDT 
The following layout test is failing on all Chromium canary bots:

fast/forms/input-widths.html

Probable cause:
http://trac.webkit.org/changeset/124314
Comment 1 yosin 2012-08-02 00:30:29 PDT 
Created attachment 155990 [details]
Patch 1
Comment 2 yosin 2012-08-02 00:31:06 PDT 
Comment on attachment 155990 [details]
Patch 1

Could you review this patch?
Thanks in advance.
Comment 3 Kent Tamura 2012-08-02 00:35:34 PDT 
Comment on attachment 155990 [details]
Patch 1

We should remove test cases for date, datetime, datetimelocal, month, and week too.
They are not reasonable any more.
Comment 4 yosin 2012-08-02 00:55:20 PDT 
Created attachment 155994 [details]
Patch 2
Comment 5 yosin 2012-08-02 00:59:05 PDT 
Created attachment 155995 [details]
Patch 3
Comment 6 yosin 2012-08-02 01:01:32 PDT 
Created attachment 155997 [details]
Patch 4
Comment 7 yosin 2012-08-02 01:02:58 PDT 
Comment on attachment 155997 [details]
Patch 4

Could you review this patch?
Thanks in advance.

= Changes since the last review =
* Remove "date", "datetime", "datetime-local", "month", "time" and "week" test cases and expectations
* Remove "color" test sample
* Update ChangeLog
Comment 8 Kent Tamura 2012-08-02 01:07:12 PDT 
Comment on attachment 155997 [details]
Patch 4

r- because of purple EWS
Comment 9 yosin 2012-08-02 01:13:07 PDT 
Created attachment 155999 [details]
Patch 5
Comment 10 yosin 2012-08-02 01:14:06 PDT 
Comment on attachment 155999 [details]
Patch 5

Could you review this patch?
Thanks in advance.

= Changes since the last review =
* Rebase LayoutTest/platform/chromium/TestExpectations
Comment 11 Kent Tamura 2012-08-02 01:15:52 PDT 
Comment on attachment 155999 [details]
Patch 5

ok.  Thanks!
Comment 12 yosin 2012-08-02 01:17:25 PDT 
Comment on attachment 155999 [details]
Patch 5

Clearing flags on attachment: 155999

Committed r124419: <http://trac.webkit.org/changeset/124419>
Comment 13 yosin 2012-08-02 01:17:30 PDT 
All reviewed patches have been landed.  Closing bug.