Bug 92858 - [Chromium] Toggle the type of ant compile for webkit_unit_tests and TestWebKitAPI
Summary: [Chromium] Toggle the type of ant compile for webkit_unit_tests and TestWebKi...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Peter Beverloo
URL:
Keywords:
Depends on:
Blocks: 66687 90920
  Show dependency tree / graph
 
Reported: 2012-08-01 03:21 PDT by Peter Beverloo
Modified: 2012-08-02 08:09 PDT (History)
2 users (show)

See Also:

Attachments
Patch (3.10 KB, patch)
2012-08-01 03:23 PDT, Peter Beverloo 		no flags Details | Formatted Diff | Diff
Patch (3.06 KB, patch)
2012-08-02 06:44 PDT, Peter Beverloo 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Peter Beverloo 2012-08-01 03:21:06 PDT 
[Chromium] Toggle the type of ant compile for webkit_unit_tests and TestWebKitAPI
Comment 1 Peter Beverloo 2012-08-01 03:23:31 PDT 
Created attachment 155770 [details]
Patch
Comment 2 Peter Beverloo 2012-08-01 05:32:55 PDT 
Comment on attachment 155770 [details]
Patch

Interdependencies keep on biting.. removing cq? for now, figuring out where some chromium code went.
Comment 3 Peter Beverloo 2012-08-01 05:39:37 PDT 
Patch on the Chromium side is here:
https://chromiumcodereview.appspot.com/10821128/
Comment 4 Peter Beverloo 2012-08-02 06:44:08 PDT 
Created attachment 156070 [details]
Patch
Comment 5 Peter Beverloo 2012-08-02 06:44:50 PDT 
Comment on attachment 156070 [details]
Patch

Same patch, but renamed "--ant-compile" to "--sdk-build" to follow the new Chromium name.

Setting cq+.
Comment 6 WebKit Review Bot 2012-08-02 08:09:27 PDT 
Comment on attachment 156070 [details]
Patch

Clearing flags on attachment: 156070

Committed r124457: <http://trac.webkit.org/changeset/124457>
Comment 7 WebKit Review Bot 2012-08-02 08:09:31 PDT 
All reviewed patches have been landed.  Closing bug.