Bug 92848 – Attempt to fix flakiness of color-suggestion-picker-appearance.html

• Status: RESOLVED
• Resolution: FIXED
• Component: Forms

[Keishi Hattori]

We observed console.log bleeding into the next test.

[Keishi Hattori]

Created attachment 155745 [details]
Patch

[Kent Tamura]

Comment on attachment 155745 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=155745&action=review

> Source/WebCore/ChangeLog:10
> +        (ColorPicker.prototype._layout): We put the width and height into
> +        variables so we don't call window.onresize twice.

Why window.onresize is called twice with the current code?

[Keishi Hattori]

(In reply to comment #2)
> (From update of attachment 155745 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=155745&action=review
> 
> > Source/WebCore/ChangeLog:10
> > +        (ColorPicker.prototype._layout): We put the width and height into
> > +        variables so we don't call window.onresize twice.
> 
> Why window.onresize is called twice with the current code?

My theory is that this._element.offsetHeight is causing a layout, which asks the window to resize immediately.

[Kent Tamura]

Comment on attachment 155745 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=155745&action=review

>>> Source/WebCore/ChangeLog:10
>>> +        variables so we don't call window.onresize twice.
>> 
>> Why window.onresize is called twice with the current code?
> 
> My theory is that this._element.offsetHeight is causing a layout, which asks the window to resize immediately.

I don't think so. Layout doesn't change the window size basically.
Did you reproduce the problem locally, and confirmed the fix by this change?

[Keishi Hattori]

(In reply to comment #4)
> > My theory is that this._element.offsetHeight is causing a layout, which asks the window to resize immediately.
> 
> I don't think so. Layout doesn't change the window size basically.
> Did you reproduce the problem locally, and confirmed the fix by this change?

Here is the stack trace. It seems to be true.

WebCore::EventHandler::sendResizeEvent()
WebCore::FrameView::performPostLayoutTasks()
WebCore::FrameView::layout(bool)
WebCore::RenderWidget::updateWidgetPosition()
WebCore::RenderView::updateWidgetPositions()
WebCore::FrameView::performPostLayoutTasks()
WebCore::FrameView::layout(bool)
WebCore::Document::updateLayout()
WebCore::Document::updateLayout()
WebCore::Document::updateLayoutIgnorePendingStylesheets()
WebCore::Element::offsetHeight()
...

[Kent Tamura]

So, did you reproduce the problem locally, and confirmed the fix?

[Keishi Hattori]

(In reply to comment #6)
> So, did you reproduce the problem locally, and confirmed the fix?

Yes, I did.

[Kent Tamura]

Comment on attachment 155745 [details]
Patch

ok

[WebKit Review Bot]

Comment on attachment 155745 [details]
Patch

Clearing flags on attachment: 155745

Committed r124326: <http://trac.webkit.org/changeset/124326>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.