Bug 92839 - Dropping webkit prefix from Battery Status API
Summary: Dropping webkit prefix from Battery Status API
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL: http://www.w3.org/TR/battery-status/
Keywords:
Depends on: 92964
Blocks:
  Show dependency treegraph
 
Reported: 2012-07-31 22:13 PDT by Kihong Kwon
Modified: 2016-11-02 14:37 PDT (History)
10 users (show)

See Also:


Attachments
Patch (10.87 KB, patch)
2012-08-01 02:33 PDT, Kihong Kwon
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kihong Kwon 2012-07-31 22:13:44 PDT
I would like to drop webkit prefix from Battery Status API.
- Battery Status API have been changed CR.
- Mozilla implemented Battery Status API to the Gecko and the Firefox enabled this API already.
Comment 1 Kihong Kwon 2012-08-01 02:33:51 PDT
Created attachment 155765 [details]
Patch
Comment 2 Adam Barth 2012-08-01 11:21:58 PDT
This API is more substantial than the vibrate API, so having a test suite makes more sense.  Is there a test suite that we and Firefox pass?
Comment 3 Kihong Kwon 2012-08-02 04:20:34 PDT
(In reply to comment #2)
> This API is more substantial than the vibrate API, so having a test suite makes more sense.  Is there a test suite that we and Firefox pass?

I made a test case.
http://hackerslab.eu/test/batterystatus.html

We can see the same result between Firefox and Efl test browser.
Thank you.
Comment 4 Peter Beverloo 2012-08-02 06:53:19 PDT
Per Anssi (who I've cc'ed): there is an action item for writing a test-suite for the Battery Status and Vibration APIs. Kihong, do you think we should wait for that -maybe contribute our tests to it?- to verify the implementation prior to unprefixing?

https://www.w3.org/2009/dap/track/actions/523

For reference, bug 92964 came up today, which was an incompatibility that should have been caught by some test.
Comment 5 Kihong Kwon 2012-08-03 00:42:36 PDT
Comment on attachment 155765 [details]
Patch

I agree. When battery test cases is opened, I will raise this issue after testing.
Comment 6 Anssi Kostiainen 2012-08-24 04:39:39 PDT
I started working on a test suite for the Battery Status API:

http://w3c-test.org/dap/battery/tests/submissions/anssik/

It is work in progress, I'll let you know when the test coverage improves.

Do you have re-usable test assets? I'm using testharness.js as the test framework.
Comment 7 Simon Fraser (smfr) 2016-11-02 14:37:57 PDT
We removed this API in https://trac.webkit.org/changeset/208300