Bug 92830 - Read tag names and attributes from the saved tokens in HTMLElementStack
Summary: Read tag names and attributes from the saved tokens in HTMLElementStack
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kwang Yul Seo
URL:
Keywords:
Depends on: 92838
Blocks: 92057
  Show dependency tree / graph
 
Reported: 2012-07-31 19:52 PDT by Kwang Yul Seo
Modified: 2012-08-01 15:57 PDT (History)
2 users (show)

See Also:

Attachments
Patch (2.45 KB, patch)
2012-07-31 19:55 PDT, Kwang Yul Seo 		no flags Details | Formatted Diff | Diff
Patch (2.46 KB, patch)
2012-07-31 20:06 PDT, Kwang Yul Seo 		no flags Details | Formatted Diff | Diff
Patch (5.01 KB, patch)
2012-07-31 22:19 PDT, Kwang Yul Seo 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kwang Yul Seo 2012-07-31 19:52:34 PDT 
This is a follow-up patch for r123577. Changed top()->hasTagName(x) with topStackItem()->hasTagName(x).
Comment 1 Kwang Yul Seo 2012-07-31 19:55:58 PDT 
Created attachment 155707 [details]
Patch
Comment 2 Kwang Yul Seo 2012-07-31 20:06:40 PDT 
Created attachment 155709 [details]
Patch
Comment 3 Kwang Yul Seo 2012-07-31 20:28:36 PDT 
(In reply to comment #2)
> Created an attachment (id=155709) [details]
> Patch

I should have replaced item->element()->hasTagName(x) with item->hasTagName(x) too. I will upload the updated patch.
Comment 4 Kwang Yul Seo 2012-07-31 22:19:29 PDT 
Created attachment 155721 [details]
Patch
Comment 5 Kwang Yul Seo 2012-07-31 22:21:37 PDT 
(In reply to comment #4)
> Created an attachment (id=155721) [details]
> Patch

This patch revealed a bug in the previous patches. Please review Bug 92838 first.
Comment 6 Kwang Yul Seo 2012-08-01 15:57:01 PDT 
Comment on attachment 155721 [details]
Patch

Clearing flags on attachment: 155721

Committed r124379: <http://trac.webkit.org/changeset/124379>
Comment 7 Kwang Yul Seo 2012-08-01 15:57:06 PDT 
All reviewed patches have been landed.  Closing bug.