Bug 92826 – Use performance.webkitNow in PerfTestRunner

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Ryosuke Niwa]

Use performance.webkitNow in PerfTestRunner

[Ryosuke Niwa]

Created attachment 155706 [details]
Patch

[Zoltan Horvath]

Comment on attachment 155706 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=155706&action=review

It looks okay, just 1 nit:

> PerformanceTests/ChangeLog:8
> +        Use performance.webkitNow with Date.now as a fallback for more acurate time measurements.

accurate

[Eric Seidel (no email)]

Comment on attachment 155706 [details]
Patch

OK.

[Ryosuke Niwa]

Created attachment 157069 [details]
Performance tests results for 155706

[Ryosuke Niwa]

Created attachment 157080 [details]
Performance tests results for 155706

[WebKit Review Bot]

Comment on attachment 155706 [details]
Patch

Clearing flags on attachment: 155706

Committed r128562: <http://trac.webkit.org/changeset/128562>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[WebKit Review Bot]

Re-opened since this is blocked by 96747

[Csaba Osztrogonác]

(In reply to comment #8)
> Re-opened since this is blocked by 96747

rolled out by http://trac.webkit.org/changeset/128579, because it broke
perf tests on Chromium and on Qt:
- http://build.webkit.org/builders/Qt%20Linux%2064-bit%20Release%20%28WebKit2%20Perf%29/builds/4036/steps/perf-test/logs/stdio
- http://build.webkit.org/builders/Chromium%20Win%20Release%20%28Perf%29/builds/3430/steps/perf-test/logs/stdio
- ....

[Ryosuke Niwa]

WTF... that makes no effing sense what so ever. Since this is a non-critical bug, I'm not gonna fix it now. I'm too annoyed.

[Taiju Tsuiki]

Comment on attachment 155706 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=155706&action=review

> PerformanceTests/resources/runner.js:26
> +PerfTestRunner.now = window.performance && window.performance.webkitNow ? window.performance.webkitNow : Date.now;

window.performance.webkitNow seems not to work without window.performance as this.
How about using function() { return performance.webkitNow(); } instead?

[Ryosuke Niwa]

(In reply to comment #11)
>
> window.performance.webkitNow seems not to work without window.performance as this.
> How about using function() { return performance.webkitNow(); } instead?

Ah, I see. Thanks for pointing that out. It's very annoying that this function requires this to be window.performance. I guess that's expected as I get the same error on Firefox. It's not clear why I wasn't getting the same error previously.

[Ryosuke Niwa]

Committed r128649: <http://trac.webkit.org/changeset/128649>