Bug 92826 - Use performance.webkitNow in PerfTestRunner
Summary: Use performance.webkitNow in PerfTestRunner
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords:
Depends on: 96747
Blocks: 77037
  Show dependency treegraph
 
Reported: 2012-07-31 19:48 PDT by Ryosuke Niwa
Modified: 2012-09-14 13:50 PDT (History)
5 users (show)

See Also:


Attachments
Patch (2.21 KB, patch)
2012-07-31 19:51 PDT, Ryosuke Niwa
no flags Details | Formatted Diff | Diff
Performance tests results for 155706 (6.49 KB, text/html)
2012-08-07 18:18 PDT, Ryosuke Niwa
no flags Details
Performance tests results for 155706 (6.49 KB, text/html)
2012-08-07 18:45 PDT, Ryosuke Niwa
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2012-07-31 19:48:11 PDT
Use performance.webkitNow in PerfTestRunner
Comment 1 Ryosuke Niwa 2012-07-31 19:51:07 PDT
Created attachment 155706 [details]
Patch
Comment 2 Zoltan Horvath 2012-08-01 00:54:26 PDT
Comment on attachment 155706 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=155706&action=review

It looks okay, just 1 nit:

> PerformanceTests/ChangeLog:8
> +        Use performance.webkitNow with Date.now as a fallback for more acurate time measurements.

accurate
Comment 3 Eric Seidel (no email) 2012-08-07 15:37:27 PDT
Comment on attachment 155706 [details]
Patch

OK.
Comment 4 Ryosuke Niwa 2012-08-07 18:18:31 PDT
Created attachment 157069 [details]
Performance tests results for 155706
Comment 5 Ryosuke Niwa 2012-08-07 18:45:43 PDT
Created attachment 157080 [details]
Performance tests results for 155706
Comment 6 WebKit Review Bot 2012-09-14 00:03:05 PDT
Comment on attachment 155706 [details]
Patch

Clearing flags on attachment: 155706

Committed r128562: <http://trac.webkit.org/changeset/128562>
Comment 7 WebKit Review Bot 2012-09-14 00:03:09 PDT
All reviewed patches have been landed.  Closing bug.
Comment 8 WebKit Review Bot 2012-09-14 03:18:27 PDT
Re-opened since this is blocked by 96747
Comment 10 Ryosuke Niwa 2012-09-14 08:41:06 PDT
WTF... that makes no effing sense what so ever. Since this is a non-critical bug, I'm not gonna fix it now. I'm too annoyed.
Comment 11 Taiju Tsuiki 2012-09-14 09:50:07 PDT
Comment on attachment 155706 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=155706&action=review

> PerformanceTests/resources/runner.js:26
> +PerfTestRunner.now = window.performance && window.performance.webkitNow ? window.performance.webkitNow : Date.now;

window.performance.webkitNow seems not to work without window.performance as this.
How about using function() { return performance.webkitNow(); } instead?
Comment 12 Ryosuke Niwa 2012-09-14 10:08:42 PDT
(In reply to comment #11)
>
> window.performance.webkitNow seems not to work without window.performance as this.
> How about using function() { return performance.webkitNow(); } instead?

Ah, I see. Thanks for pointing that out. It's very annoying that this function requires this to be window.performance. I guess that's expected as I get the same error on Firefox. It's not clear why I wasn't getting the same error previously.
Comment 13 Ryosuke Niwa 2012-09-14 13:50:40 PDT
Committed r128649: <http://trac.webkit.org/changeset/128649>