Bug 92810 - [chromium] Use skia directly in CCHeadsUpDisplayLayerImpl
Summary: [chromium] Use skia directly in CCHeadsUpDisplayLayerImpl
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: James Robinson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-07-31 16:33 PDT by James Robinson
Modified: 2012-07-31 17:34 PDT (History)
6 users (show)

See Also:

Attachments
Patch (24.17 KB, patch)
2012-07-31 16:35 PDT, James Robinson 		enne: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description James Robinson 2012-07-31 16:33:34 PDT 
[chromium] Use skia directly in CCHeadsUpDisplayLayerImpl
Comment 1 James Robinson 2012-07-31 16:35:02 PDT 
Created attachment 155673 [details]
Patch
Comment 2 Adrienne Walker 2012-07-31 17:12:00 PDT 
Comment on attachment 155673 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=155673&action=review

R=me, assuming you tested FPS and debug geometry manually.  It'd be nice at some point to have automated HUD tests even if this is just a debug feature.

> Source/WebCore/WebCore.gypi:-8268
> -            'platform/graphics/chromium/PlatformCanvas.cpp',
> -            'platform/graphics/chromium/PlatformCanvas.h',

<3
Comment 3 James Robinson 2012-07-31 17:22:41 PDT 
--show-fps-counter, --show-paint-rects and --show-composited-layer-tree appear to behave the same as before.  Automated tests of some form would be definitely be nice!
Comment 4 James Robinson 2012-07-31 17:34:56 PDT 
Committed r124275: <http://trac.webkit.org/changeset/124275>