Bug 92807 - Remove unused method HTMLElementStack::bottom()
Summary: Remove unused method HTMLElementStack::bottom()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kwang Yul Seo
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-07-31 16:19 PDT by Kwang Yul Seo
Modified: 2012-07-31 17:52 PDT (History)
2 users (show)

See Also:


Attachments
Patch (2.07 KB, patch)
2012-07-31 16:21 PDT, Kwang Yul Seo
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kwang Yul Seo 2012-07-31 16:19:14 PDT
HTMLElementStack::bottom() was replaced with HTMLElementStack::rootNode() in r80231.
Comment 1 Kwang Yul Seo 2012-07-31 16:21:01 PDT
Created attachment 155667 [details]
Patch
Comment 2 Kwang Yul Seo 2012-07-31 16:33:40 PDT
BTW, r80231 (Bug 48719) seems to be the major source of complexity and irregularity in the HTML parser because HTMLElementStack needs to handle not only Element but also ContainerNode after r80231. I understand this is a necessary evil for performance reasons, but I hope we could lessen the complexity.
Comment 3 Kentaro Hara 2012-07-31 16:46:03 PDT
Comment on attachment 155667 [details]
Patch

Looks OK
Comment 4 WebKit Review Bot 2012-07-31 17:52:07 PDT
Comment on attachment 155667 [details]
Patch

Clearing flags on attachment: 155667

Committed r124277: <http://trac.webkit.org/changeset/124277>
Comment 5 WebKit Review Bot 2012-07-31 17:52:10 PDT
All reviewed patches have been landed.  Closing bug.