WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
Bug 92807
Remove unused method HTMLElementStack::bottom()
https://bugs.webkit.org/show_bug.cgi?id=92807
Summary
Remove unused method HTMLElementStack::bottom()
Kwang Yul Seo
Reported
2012-07-31 16:19:14 PDT
HTMLElementStack::bottom() was replaced with HTMLElementStack::rootNode() in
r80231
.
Attachments
Patch
(2.07 KB, patch)
2012-07-31 16:21 PDT
,
Kwang Yul Seo
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Kwang Yul Seo
Comment 1
2012-07-31 16:21:01 PDT
Created
attachment 155667
[details]
Patch
Kwang Yul Seo
Comment 2
2012-07-31 16:33:40 PDT
BTW,
r80231
(
Bug 48719
) seems to be the major source of complexity and irregularity in the HTML parser because HTMLElementStack needs to handle not only Element but also ContainerNode after
r80231
. I understand this is a necessary evil for performance reasons, but I hope we could lessen the complexity.
Kentaro Hara
Comment 3
2012-07-31 16:46:03 PDT
Comment on
attachment 155667
[details]
Patch Looks OK
WebKit Review Bot
Comment 4
2012-07-31 17:52:07 PDT
Comment on
attachment 155667
[details]
Patch Clearing flags on attachment: 155667 Committed
r124277
: <
http://trac.webkit.org/changeset/124277
>
WebKit Review Bot
Comment 5
2012-07-31 17:52:10 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug