Bug 92796 - Pointer lock blocked for sandboxed iframes.
Summary: Pointer lock blocked for sandboxed iframes.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Vincent Scheib
URL:
Keywords:
Depends on:
Blocks: 84402
  Show dependency tree / graph
 
Reported: 2012-07-31 15:28 PDT by Vincent Scheib
Modified: 2012-08-20 13:53 PDT (History)
4 users (show)

See Also:

Attachments
Patch (5.30 KB, patch)
2012-07-31 15:36 PDT, Vincent Scheib 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from gce-cr-linux-05 (535.05 KB, application/zip)
2012-07-31 16:32 PDT, WebKit Review Bot 		no flags Details
Patch (4.88 KB, patch)
2012-08-01 10:41 PDT, Vincent Scheib 		no flags Details | Formatted Diff | Diff
Patch (5.49 KB, patch)
2012-08-01 11:11 PDT, Vincent Scheib 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Vincent Scheib 2012-07-31 15:28:44 PDT 
Pointer lock blocked for sandboxed iframes.
Comment 1 Vincent Scheib 2012-07-31 15:36:13 PDT 
Created attachment 155649 [details]
Patch
Comment 2 WebKit Review Bot 2012-07-31 16:32:36 PDT 
Comment on attachment 155649 [details]
Patch

Attachment 155649 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/13392896

New failing tests:
http/tests/pointer-lock/iframe-sandboxed.html
Comment 3 WebKit Review Bot 2012-07-31 16:32:39 PDT 
Created attachment 155672 [details]
Archive of layout-test-results from gce-cr-linux-05

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: gce-cr-linux-05  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid
Comment 4 Adrienne Walker 2012-07-31 16:49:41 PDT 
Comment on attachment 155649 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=155649&action=review

> Source/WebCore/ChangeLog:3
> +        Pointer lock blocked for sandboxed iframes.

Reword as "Block pointer lock for sandboxed iframes" to be more clear about what's changing in this patch?

> Source/WebCore/ChangeLog:8
> +        Additional information of the change such as approach, rationale. Please add per-function descriptions below (OOPS!).

Need to remove this line or add some more description here.

> Source/WebCore/page/PointerLockController.cpp:52
> +        || target->document()->sandboxFlags()) {

Is this going to be part of the pointer lock spec that sandboxing explicitly prohibits pointer lock or is this just Chrome-specific behavior?
Comment 5 Vincent Scheib 2012-08-01 10:41:31 PDT 
Created attachment 155838 [details]
Patch
Comment 6 Adrienne Walker 2012-08-01 10:42:57 PDT 
Comment on attachment 155838 [details]
Patch

R=me.
Comment 7 Adam Barth 2012-08-01 10:55:03 PDT 
Comment on attachment 155838 [details]
Patch

You should introduce an explicit sandbox flag for this purpose.  We have a bunch of sandbox flags that don't have syntax to unset them.
Comment 8 Adam Barth 2012-08-01 10:56:54 PDT 
For example, SandboxPlugins  <http://trac.webkit.org/browser/trunk/Source/WebCore/dom/SecurityContext.h#L44> doesn't have any syntax yet.
Comment 9 Vincent Scheib 2012-08-01 11:11:49 PDT 
Created attachment 155845 [details]
Patch
Comment 10 Adam Barth 2012-08-01 11:53:25 PDT 
Comment on attachment 155845 [details]
Patch

Perfect, thanks.
Comment 11 WebKit Review Bot 2012-08-01 14:22:11 PDT 
Comment on attachment 155845 [details]
Patch

Clearing flags on attachment: 155845

Committed r124368: <http://trac.webkit.org/changeset/124368>
Comment 12 WebKit Review Bot 2012-08-01 14:22:16 PDT 
All reviewed patches have been landed.  Closing bug.