Bug 92796 – Pointer lock blocked for sandboxed iframes.

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Vincent Scheib]

Pointer lock blocked for sandboxed iframes.

[Vincent Scheib]

Created attachment 155649 [details]
Patch

[WebKit Review Bot]

Comment on attachment 155649 [details]
Patch

Attachment 155649 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/13392896

New failing tests:
http/tests/pointer-lock/iframe-sandboxed.html

[WebKit Review Bot]

Created attachment 155672 [details]
Archive of layout-test-results from gce-cr-linux-05

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: gce-cr-linux-05  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid

[Adrienne Walker]

Comment on attachment 155649 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=155649&action=review

> Source/WebCore/ChangeLog:3
> +        Pointer lock blocked for sandboxed iframes.

Reword as "Block pointer lock for sandboxed iframes" to be more clear about what's changing in this patch?

> Source/WebCore/ChangeLog:8
> +        Additional information of the change such as approach, rationale. Please add per-function descriptions below (OOPS!).

Need to remove this line or add some more description here.

> Source/WebCore/page/PointerLockController.cpp:52
> +        || target->document()->sandboxFlags()) {

Is this going to be part of the pointer lock spec that sandboxing explicitly prohibits pointer lock or is this just Chrome-specific behavior?

[Vincent Scheib]

Created attachment 155838 [details]
Patch

[Adrienne Walker]

Comment on attachment 155838 [details]
Patch

R=me.

[Adam Barth]

Comment on attachment 155838 [details]
Patch

You should introduce an explicit sandbox flag for this purpose.  We have a bunch of sandbox flags that don't have syntax to unset them.

[Adam Barth]

For example, SandboxPlugins  <http://trac.webkit.org/browser/trunk/Source/WebCore/dom/SecurityContext.h#L44> doesn't have any syntax yet.

[Vincent Scheib]

Created attachment 155845 [details]
Patch

[Adam Barth]

Comment on attachment 155845 [details]
Patch

Perfect, thanks.

[WebKit Review Bot]

Comment on attachment 155845 [details]
Patch

Clearing flags on attachment: 155845

Committed r124368: <http://trac.webkit.org/changeset/124368>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.