Bug 92783 – IndexedDB: intversion-long-queue.html fails an assert

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[David Grogan]

But only when run without any of the integer version code.

[David Grogan]

STDERR: ASSERTION FAILED: m_readyState == PENDING || m_readyState == DONE
STDERR: ../../third_party/WebKit/Source/WebCore/Modules/indexeddb/IDBRequest.cpp(222) : virtual void WebCore::IDBRequest::onError(PassRefPtr<WebCore::IDBDatabaseError>)
STDERR: 	WebCore::IDBRequest::onError() [0x7ff87bb9cb6d]
STDERR: 	WebKit::WebIDBCallbacksImpl::onError() [0x7ff87aae3e27]
STDERR: 	WebKit::IDBCallbacksProxy::onError() [0x7ff87aa66654]
STDERR: 	WebCore::IDBDatabaseBackendImpl::setVersion() [0x7ff87bb4e837]
STDERR: 	WebCore::IDBDatabaseBackendImpl::processPendingCalls() [0x7ff87bb4f397]
STDERR: 	WebCore::IDBDatabaseBackendImpl::close() [0x7ff87bb501ae]
STDERR: 	WebKit::WebIDBDatabaseImpl::close() [0x7ff87aae6424]
STDERR: 	WebKit::IDBDatabaseBackendProxy::close() [0x7ff87aa69c4d]
STDERR: 	WebCore::IDBDatabase::closeConnection() [0x7ff87bb476ab]
STDERR: 	WebCore::IDBDatabase::close() [0x7ff87bb47135]
STDERR: 	WebCore::IDBDatabase::stop() [0x7ff87bb48fde]
STDERR: 	WebCore::IDBDatabase::stop() [0x7ff87bb4900c]
STDERR: 	WebCore::ScriptExecutionContext::stopActiveDOMObjects() [0x7ff87b6a7cad]
STDERR: 	WebCore::Document::detach() [0x7ff87b5c5464]
STDERR: 	WebCore::Document::prepareForDestruction() [0x7ff87b5c5933]
STDERR: 	WebCore::Frame::setView() [0x7ff87c218406]
STDERR: 	WebCore::Frame::createView() [0x7ff87c21b176]
STDERR: 	WebKit::WebFrameImpl::createFrameView() [0x7ff87aad004c]
STDERR: 	WebKit::FrameLoaderClientImpl::makeDocumentView() [0x7ff87aa5a2a9]
STDERR: 	WebKit::FrameLoaderClientImpl::transitionToCommittedForNewPage() [0x7ff87aa5e6c5]
STDERR: 	WebCore::FrameLoader::transitionToCommitted() [0x7ff87c153e65]
STDERR: 	WebCore::FrameLoader::commitProvisionalLoad() [0x7ff87c1532c8]
STDERR: 	WebCore::DocumentLoader::commitIfReady() [0x7ff87c12a10c]
STDERR: 	WebCore::DocumentLoader::commitLoad() [0x7ff87c12a72c]
STDERR: 	WebCore::DocumentLoader::receivedData() [0x7ff87c12ab03]
STDERR: 	WebCore::MainResourceLoader::addData() [0x7ff87c1695e7]
STDERR: 	WebCore::ResourceLoader::didReceiveData() [0x7ff87c1810ac]
STDERR: 	WebCore::MainResourceLoader::didReceiveData() [0x7ff87c16ad3d]
STDERR: 	WebCore::ResourceLoader::didReceiveData() [0x7ff87c1819fd]
STDERR: 	WebCore::ResourceHandleInternal::didReceiveData() [0x7ff87bade2a9]
STDERR: 	webkit_glue::WebURLLoaderImpl::Context::OnReceivedData() [0x7ff87f32181a]
STDERR: 	(anonymous namespace)::RequestProxy::NotifyReceivedData() [0x5c53ca]
STDERR: 	base::internal::RunnableAdapter<>::Run() [0x5c5719]
STDERR: 	base::internal::InvokeHelper<>::MakeItSo() [0x5c5681]
STDERR: 	base::internal::Invoker<>::Run() [0x5c562c]
STDERR: 	base::Callback<>::Run() [0x7ff87efd348e]
STDERR: 	MessageLoop::RunTask() [0x7ff87f01c554]
STDERR: 	MessageLoop::DeferOrRunPendingTask() [0x7ff87f01c86b]
STDERR: 	MessageLoop::DoWork() [0x7ff87f01ca45]

[David Grogan]

Created attachment 157326 [details]
Patch

[David Grogan]

Josh or Alec, could you give this a look?

[Joshua Bell]

Comment on attachment 157326 [details]
Patch

LGTM

On a tangent, it occurs to me that the onSuccess(PassRefPtr<IDBTransactionBackendInterface>) method of IDBCallbacks.h should only apply to version change requests - we could move the body of that method to IDBVersionChangeRequest, couldn't we?

[David Grogan]

Tony, could you review this?

(In reply to comment #4)
> On a tangent, it occurs to me that the onSuccess(PassRefPtr<IDBTransactionBackendInterface>) method of IDBCallbacks.h should only apply to version change requests - we could move the body of that method to IDBVersionChangeRequest, couldn't we?

I think so.

[Tony Chang]

Comment on attachment 157326 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=157326&action=review

> LayoutTests/storage/indexeddb/intversion-long-queue-expected.txt:69
> -PASS gotUpgradeNeededEvent is true
> +FAIL gotUpgradeNeededEvent should be true. Was false.

Why does this fail?

[Tony Chang]

Comment on attachment 157326 [details]
Patch

Nevermind, I didn't read the changelog.  Sorry!

[WebKit Review Bot]

Comment on attachment 157326 [details]
Patch

Rejecting attachment 157326 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:

CONFLICT (content): Merge conflict in Source/WebCore/ChangeLog
Failed to merge in the changes.
Patch failed at 0001 Unreviewed, update TestExpectations for chromium gardening.

When you have resolved this problem run "git rebase --continue".
If you would prefer to skip this patch, instead run "git rebase --skip".
To restore the original branch and stop rebasing run "git rebase --abort".

rebase refs/remotes/origin/master: command returned error: 1

Died at Tools/Scripts/update-webkit line 164.

Full output: http://queues.webkit.org/results/13464255

[David Grogan]

Created attachment 157555 [details]
Patch for landing

[WebKit Review Bot]

Comment on attachment 157555 [details]
Patch for landing

Rejecting attachment 157555 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
t 0001 [V8] Rename V8BindingPerIsolateData to V8PerIsolateData

When you have resolved this problem run "git rebase --continue".
If you would prefer to skip this patch, instead run "git rebase --skip".
To restore the original branch and stop rebasing run "git rebase --abort".

rebase refs/remotes/origin/master: command returned error: 1

Died at Tools/Scripts/update-webkit line 164.

Failed to run "['Tools/Scripts/update-webkit', '--chromium', '--force-update']" exit_code: 9
te-webkit line 164.

Full output: http://queues.webkit.org/results/13463513

[David Grogan]

Created attachment 157585 [details]
Patch for landing

[WebKit Review Bot]

Comment on attachment 157585 [details]
Patch for landing

Clearing flags on attachment: 157585

Committed r125231: <http://trac.webkit.org/changeset/125231>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.