Bug 92779 - Gesture click test should validate click count in UIEvent.detail
Summary: Gesture click test should validate click count in UIEvent.detail
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Rick Byers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-07-31 11:45 PDT by Rick Byers
Modified: 2019-02-06 09:19 PST (History)
3 users (show)

See Also:


Attachments
Patch (6.15 KB, patch)
2012-07-31 12:58 PDT, Rick Byers
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Rick Byers 2012-07-31 11:45:14 PDT
As part of adding gesture support for sending the dblclick event (Bug 92412), I noticed the fast/events/touch/gesture/gesture-click.html test wasn't explicitly testing the 'detail' field of the event to verify it's '1' for the generate mousedown/mouseup/click events and '0' for mousemove.  See http://www.w3.org/TR/DOM-Level-3-Events/#current-click-count
Comment 1 Rick Byers 2012-07-31 12:58:27 PDT
Created attachment 155609 [details]
Patch
Comment 2 Robert Kroeger 2012-08-01 11:42:00 PDT
Nice. This looks good to me.

abarth@: Could you review?
Comment 3 WebKit Review Bot 2012-08-01 13:10:36 PDT
Comment on attachment 155609 [details]
Patch

Clearing flags on attachment: 155609

Committed r124359: <http://trac.webkit.org/changeset/124359>
Comment 4 WebKit Review Bot 2012-08-01 13:10:40 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 Lucas Forschler 2019-02-06 09:19:15 PST
Mass move bugs into the DOM component.