Bug 92775 - [chromium] REGRESSION(r123644) Compositor HUD crashes immediately with --show-paint-rects
Summary: [chromium] REGRESSION(r123644) Compositor HUD crashes immediately with --show...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: James Robinson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-07-31 11:20 PDT by James Robinson
Modified: 2012-08-01 13:09 PDT (History)
6 users (show)

See Also:


Attachments
Patch (5.66 KB, patch)
2012-07-31 11:23 PDT, James Robinson
no flags Details | Formatted Diff | Diff
Patch (6.95 KB, patch)
2012-07-31 13:24 PDT, James Robinson
enne: review+
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description James Robinson 2012-07-31 11:20:56 PDT
[chromium] REGRESSION(r123644) Compositor HUD crashes immediately with --show-paint-rects
Comment 1 James Robinson 2012-07-31 11:23:47 PDT
Created attachment 155588 [details]
Patch
Comment 2 Adrienne Walker 2012-07-31 12:08:01 PDT
Comment on attachment 155588 [details]
Patch

I mentioned this offline, but I think the bounds should get set every frame rather than in the constructor.  While you're touching that code, is it possible to fix the extra commits from the HUD by not adding and removing it every frame?
Comment 3 James Robinson 2012-07-31 13:24:28 PDT
Created attachment 155619 [details]
Patch
Comment 4 James Robinson 2012-07-31 13:24:38 PDT
PTAL
Comment 5 Adrienne Walker 2012-07-31 14:30:19 PDT
Comment on attachment 155619 [details]
Patch

R=me.  Thanks.
Comment 6 WebKit Review Bot 2012-07-31 16:17:21 PDT
Comment on attachment 155619 [details]
Patch

Rejecting attachment 155619 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
nes.
Auto-merging LayoutTests/ChangeLog
CONFLICT (content): Merge conflict in LayoutTests/ChangeLog
Failed to merge in the changes.
Patch failed at 0001 [Chromium] Rebaselines.

When you have resolved this problem run "git rebase --continue".
If you would prefer to skip this patch, instead run "git rebase --skip".
To restore the original branch and stop rebasing run "git rebase --abort".

rebase refs/remotes/origin/master: command returned error: 1

Died at Tools/Scripts/update-webkit line 164.

Full output: http://queues.webkit.org/results/13392881
Comment 7 James Robinson 2012-07-31 16:31:22 PDT
Committed r124269: <http://trac.webkit.org/changeset/124269>
Comment 8 Shawn Singh 2012-08-01 11:37:30 PDT
Is this actually fixed?  I'm still getting crashes with --show-paint-rects and --show-composited-layer-tree.  but --show-fps-counter seems to work fine.
Comment 9 James Robinson 2012-08-01 12:19:57 PDT
(In reply to comment #8)
> Is this actually fixed?  I'm still getting crashes with --show-paint-rects and --show-composited-layer-tree.  but --show-fps-counter seems to work fine.

Seems OK for me in debug on linux, at least on poster circle.  Can you get a stacktrace and open a new bug?
Comment 10 Shawn Singh 2012-08-01 13:09:50 PDT
(In reply to comment #9)
> (In reply to comment #8)
> > Is this actually fixed?  I'm still getting crashes with --show-paint-rects and --show-composited-layer-tree.  but --show-fps-counter seems to work fine.
> 
> Seems OK for me in debug on linux, at least on poster circle.  Can you get a stacktrace and open a new bug?

My mistake - this was a false alarm.  I thought I was on tip-of-tree, but actually I had not rebased my git branch.