Bug 92773 - REGRESSION(r124207): Patch causes crashes on the 64-bit debug builder (and other builders likely) (Requested by zdobersek on #webkit).
Summary: REGRESSION(r124207): Patch causes crashes on the 64-bit debug builder (and ot...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: WebKit Review Bot
URL:
Keywords:
Depends on:
Blocks: 90269
  Show dependency treegraph
 
Reported: 2012-07-31 11:08 PDT by WebKit Review Bot
Modified: 2012-07-31 23:09 PDT (History)
3 users (show)

See Also:


Attachments
ROLLOUT of r124207 (23.66 KB, patch)
2012-07-31 11:09 PDT, WebKit Review Bot
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description WebKit Review Bot 2012-07-31 11:08:25 PDT
http://trac.webkit.org/changeset/124207 broke the build:
Patch causes crashes on the 64-bit debug builder (and other builders likely) (Requested by zdobersek on #webkit).

This is an automatic bug report generated by the sheriff-bot. If this bug
report was created because of a flaky test, please file a bug for the flaky
test (if we don't already have one on file) and dup this bug against that bug
so that we can track how often these flaky tests case pain.

"Only you can prevent forest fires." -- Smokey the Bear
Comment 1 WebKit Review Bot 2012-07-31 11:09:04 PDT
Created attachment 155587 [details]
ROLLOUT of r124207

Any committer can land this patch automatically by marking it commit-queue+.  The commit-queue will build and test the patch before landing to ensure that the rollout will be successful.  This process takes approximately 15 minutes.

If you would like to land the rollout faster, you can use the following command:

  webkit-patch land-attachment ATTACHMENT_ID

where ATTACHMENT_ID is the ID of this attachment.
Comment 2 Zan Dobersek 2012-07-31 11:11:23 PDT
The all-helping crash log:

Crash log for DumpRenderTree (pid 15821):

[New LWP 15821]
[New LWP 15830]
[New LWP 15829]
[New LWP 15835]
[New LWP 15833]
[New LWP 15831]
[New LWP 15832]
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.so.1".
Core was generated by `/home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/Programs/DumpR'.
Program terminated with signal 11, Segmentation fault.
#0  0x00007f59fbf7d85b in WebCore::TextCheckingHelper::findFirstMisspelling (this=0x7fff92a0f0c0, firstMisspellingOffset=@0x7fff92a0f07c: 0, markAll=true, firstMisspellingRange=...) at ../../Source/WebCore/editing/TextCheckingHelper.cpp:263
263	            ASSERT(misspellingLocation < len);


Thread 1 (Thread 0x7f59f02e8900 (LWP 15821)):
#0  0x00007f59fbf7d85b in WebCore::TextCheckingHelper::findFirstMisspelling (this=0x7fff92a0f0c0, firstMisspellingOffset=@0x7fff92a0f07c: 0, markAll=true, firstMisspellingRange=...) at ../../Source/WebCore/editing/TextCheckingHelper.cpp:263
#1  0x00007f59fbf7fb58 in WebCore::TextCheckingHelper::markAllMisspellings (this=0x7fff92a0f0c0, firstMisspellingRange=...) at ../../Source/WebCore/editing/TextCheckingHelper.cpp:640
#2  0x00007f59fbf381a0 in WebCore::Editor::markMisspellingsOrBadGrammar (this=0x1ea81f8, selection=..., checkSpelling=true, firstMisspellingRange=...) at ../../Source/WebCore/editing/Editor.cpp:1914
#3  0x00007f59fbf382f0 in WebCore::Editor::markMisspellings (this=0x1ea81f8, selection=..., firstMisspellingRange=...) at ../../Source/WebCore/editing/Editor.cpp:1939
#4  0x00007f59fbf3a00f in WebCore::Editor::markMisspellingsAndBadGrammar (this=0x1ea81f8, spellingSelection=..., markGrammar=false, grammarSelection=...) at ../../Source/WebCore/editing/Editor.cpp:2201
#5  0x00007f59fbf3e235 in WebCore::Editor::respondToChangedSelection (this=0x1ea81f8, oldSelection=..., options=6) at ../../Source/WebCore/editing/Editor.cpp:2828
#6  0x00007f59fbf43532 in WebCore::FrameSelection::setSelection (this=0x1ea82c0, newSelection=..., options=6, align=WebCore::FrameSelection::AlignCursorOnScrollIfNeeded, granularity=WebCore::CharacterGranularity) at ../../Source/WebCore/editing/FrameSelection.cpp:297
#7  0x00007f59fbf4827a in WebCore::FrameSelection::setExtent (this=0x1ea82c0, pos=..., userTriggered=WebCore::NotUserTriggered) at ../../Source/WebCore/editing/FrameSelection.cpp:1151
#8  0x00007f59fbf47569 in WebCore::FrameSelection::modify (this=0x1ea82c0, alter=WebCore::FrameSelection::AlterationExtend, direction=WebCore::DirectionBackward, granularity=WebCore::LineGranularity, userTriggered=WebCore::NotUserTriggered) at ../../Source/WebCore/editing/FrameSelection.cpp:967
#9  0x00007f59fc2ceb28 in WebCore::DOMSelection::modify (this=0x27eba50, alterString="extend", directionString="backward", granularityString="line") at ../../Source/WebCore/page/DOMSelection.cpp:333
#10 0x00007f59fca617fa in WebCore::jsDOMSelectionPrototypeFunctionModify (exec=0x7f59ac4cc1b0) at DerivedSources/WebCore/JSDOMSelection.cpp:491
#11 0x00007f59b00c2265 in ?? ()
#12 0x00007fff92a0fcf0 in ?? ()
#13 0x00007f5a007d397b in llint_op_call () from /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/.libs/libjavascriptcoregtk-3.0.so.0
#14 0x00007fff92a0fc80 in ?? ()
#15 0x00007fff92a0fcb0 in ?? ()
#16 0x0000000000000000 in ?? ()

This is patch is really reluctant towards the idea of not causing problems.
Comment 3 Zan Dobersek 2012-07-31 11:16:59 PDT
Comment on attachment 155587 [details]
ROLLOUT of r124207

Clearing flags on attachment: 155587

Committed r124223: <http://trac.webkit.org/changeset/124223>
Comment 4 Zan Dobersek 2012-07-31 11:17:06 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 Mario Sanchez Prada 2012-07-31 13:10:55 PDT
(In reply to comment #2)
> [...]
> This is patch is really reluctant towards the idea of not causing problems.

Agree :-/. I will take a look to it asap (hopefully this week)

In the meanwhile, would you mind to point out which layout test caused this stacktrace?

Thanks, and sorry for the hassle
Comment 6 Zan Dobersek 2012-07-31 23:09:40 PDT
Here's the list, taken from http://build.webkit.org/builders/GTK%20Linux%2064-bit%20Debug/builds/35188

editing/pasteboard/display-block-on-spans.html
editing/inserting/insert-paragraph-separator-tab-span.html
editing/inserting/insert-paste-bidi-control.html
editing/inserting/edited-whitespace-1.html
editing/inserting/insert-composition-whitespace.html
editing/pasteboard/copy-backslash-with-euc.html
editing/pasteboard/copy-in-password-field.html
editing/pasteboard/paste-text-016.html
editing/style/remove-underline-after-paragraph.html
editing/selection/extend-selection-home-end.html
editing/selection/home-end.html
editing/selection/3690703-2.html
editing/execCommand/switch-list-type.html
editing/execCommand/transpose-backslash-with-euc.html
editing/undo/undo-paste-when-caret-is-not-in-range.html
editing/spelling/grammar-edit-word.html
editing/spelling/spellcheck-async.html