Bug 92772 – Expose table internal structure to DumpRenderTree

• Status: NEW
• Component: Tables

[Julien Chaffraix]

Currently we don't dump the internal table structure anywhere (RenderTable::m_columns). We do dump physical cells location on the grid but that doesn't cover any patching we do due to different row sizes. This would make bug where the structure of the table is wrong easier to debug.

On way to do that would be to add a new method to Internals. The other one would be to modify RenderTreeAsText to dump it along the RenderTable. My favorite is Internals as we would get dumpAsText tests but I didn't spend too much time thinking about it.

[Ryosuke Niwa]

I'm not sure if this is such a good idea. We try not to expose implementation details like this elsewhere in WebKit.

[Simon Fraser (smfr)]

Agreed; I don't think we should start dumping lots of Render* state via internals. I'd vote for just enhancing the RenderTeeAsText output for tables.

(In reply to comment #2)
> Agreed; I don't think we should start dumping lots of Render* state via internals. I'd vote for just enhancing the RenderTeeAsText output for tables.

Ditto.

[Julien Chaffraix]

(In reply to comment #3)
> (In reply to comment #2)
> > Agreed; I don't think we should start dumping lots of Render* state via internals. I'd vote for just enhancing the RenderTeeAsText output for tables.
> 
> Ditto.

Just to outline why I considered Internals to be better than RenderTreeAsText _in this case_:
1) it's useful only in a pretty small subset of the table issues.
2) a render tree dump is already cramped with a lot of information and this would add another big chunk to it.

That said, I am not set up on the means, only that it would be a good information to add to our testing repertoire.