Bug 92764 - [Chromium] Don't use ninja for building Chromium for Android
Summary: [Chromium] Don't use ninja for building Chromium for Android
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Peter Beverloo
URL:
Keywords:
Depends on:
Blocks: 84843
  Show dependency treegraph
 
Reported: 2012-07-31 08:59 PDT by Peter Beverloo
Modified: 2012-07-31 10:27 PDT (History)
2 users (show)

See Also:


Attachments
Patch (1.58 KB, patch)
2012-07-31 09:00 PDT, Peter Beverloo
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Peter Beverloo 2012-07-31 08:59:18 PDT
[Chromium] Don't use ninja for building Chromium for Android
Comment 1 Peter Beverloo 2012-07-31 09:00:48 PDT
Created attachment 155554 [details]
Patch
Comment 2 Peter Beverloo 2012-07-31 09:03:16 PDT
I reverted (and Yaron re-landed) http://crrev.com/148739 on the Chromium side, which enabled creating Ninja project files. This unintentionally switched Android to using the Ninja build, which then broke.

We should eventually make the switch, but do so in a controlled and tested manner.
Comment 3 WebKit Review Bot 2012-07-31 10:27:06 PDT
Comment on attachment 155554 [details]
Patch

Clearing flags on attachment: 155554

Committed r124219: <http://trac.webkit.org/changeset/124219>
Comment 4 WebKit Review Bot 2012-07-31 10:27:10 PDT
All reviewed patches have been landed.  Closing bug.