WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
Bug 92751
Web Inspector: extract MemoryInstrumentationImpl into separate files for future reusing in unit tests
https://bugs.webkit.org/show_bug.cgi?id=92751
Summary
Web Inspector: extract MemoryInstrumentationImpl into separate files for futu...
Ilya Tikhonovsky
Reported
2012-07-31 07:23:17 PDT
EOM
Attachments
Patch
(17.04 KB, patch)
2012-07-31 07:24 PDT
,
Ilya Tikhonovsky
yurys
: review+
buildbot
: commit-queue-
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Ilya Tikhonovsky
Comment 1
2012-07-31 07:24:56 PDT
Created
attachment 155528
[details]
Patch
Build Bot
Comment 2
2012-07-31 07:35:30 PDT
Comment on
attachment 155528
[details]
Patch
Attachment 155528
[details]
did not pass mac-ews (mac): Output:
http://queues.webkit.org/results/13404050
Yury Semikhatsky
Comment 3
2012-07-31 08:11:38 PDT
Comment on
attachment 155528
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=155528&action=review
> Source/WebCore/inspector/MemoryInstrumentationImpl.h:49 > + size_t totalTypeSize(ObjectType objectType)
totalTypeSize -> totalSize
Ilya Tikhonovsky
Comment 4
2012-07-31 08:53:36 PDT
Committed
r124208
: <
http://trac.webkit.org/changeset/124208
>
WebKit Review Bot
Comment 5
2012-07-31 09:02:47 PDT
Re-opened since this is blocked by 92765
Ilya Tikhonovsky
Comment 6
2012-08-01 00:30:11 PDT
Committed
r124306
: <
http://trac.webkit.org/changeset/124306
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug