Bug 92751 - Web Inspector: extract MemoryInstrumentationImpl into separate files for future reusing in unit tests
Summary: Web Inspector: extract MemoryInstrumentationImpl into separate files for futu...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Ilya Tikhonovsky
URL:
Keywords:
Depends on: 92765
Blocks: 87262
  Show dependency tree / graph
 
Reported: 2012-07-31 07:23 PDT by Ilya Tikhonovsky
Modified: 2012-08-01 06:28 PDT (History)
14 users (show)

See Also:

Attachments
Patch (17.04 KB, patch)
2012-07-31 07:24 PDT, Ilya Tikhonovsky 		yurys: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ilya Tikhonovsky 2012-07-31 07:23:17 PDT 
EOM
Comment 1 Ilya Tikhonovsky 2012-07-31 07:24:56 PDT 
Created attachment 155528 [details]
Patch
Comment 2 Build Bot 2012-07-31 07:35:30 PDT 
Comment on attachment 155528 [details]
Patch

Attachment 155528 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/13404050
Comment 3 Yury Semikhatsky 2012-07-31 08:11:38 PDT 
Comment on attachment 155528 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=155528&action=review

> Source/WebCore/inspector/MemoryInstrumentationImpl.h:49
> +    size_t totalTypeSize(ObjectType objectType)

totalTypeSize -> totalSize
Comment 4 Ilya Tikhonovsky 2012-07-31 08:53:36 PDT 
Committed r124208: <http://trac.webkit.org/changeset/124208>
Comment 5 WebKit Review Bot 2012-07-31 09:02:47 PDT 
Re-opened since this is blocked by 92765
Comment 6 Ilya Tikhonovsky 2012-08-01 00:30:11 PDT 
Committed r124306: <http://trac.webkit.org/changeset/124306>