Implement numberOfPages, pageProperty & pageSizeAndMarginsInPixels in Internals and remove duplicated code from DumprenderTree & WebkitTestRunner.
Created attachment 155479 [details] WIP WIP for getting Mac Win symbols for implemented APIs
Comment on attachment 155479 [details] WIP Attachment 155479 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/13384906
Comment on attachment 155479 [details] WIP Attachment 155479 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/13385853
Comment on attachment 155479 [details] WIP Attachment 155479 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/13401337
Comment on attachment 155479 [details] WIP Attachment 155479 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/13386793
Comment on attachment 155479 [details] WIP Attachment 155479 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13387736 New failing tests: printing/css2.1/page-break-before-001.html printing/page-count-relayout-shrink.html printing/page-format-data.html printing/css2.1/page-break-after-000.html printing/css2.1/page-break-after-004.html printing/page-rule-selection.html printing/page-count-layout-overflow.html printing/stretch-to-view-height.html printing/css2.1/page-break-before-000.html printing/page-count-percentage-height.html printing/numberOfPages.html printing/css2.1/page-break-after-003.html printing/css2.1/page-break-after-001.html printing/css2.1/page-break-before-002.html
Created attachment 155492 [details] Archive of layout-test-results from gce-cr-linux-07 The attached test failures were seen while running run-webkit-tests on the chromium-ews. Bot: gce-cr-linux-07 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid
Created attachment 155496 [details] Patch
Comment on attachment 155496 [details] Patch Attachment 155496 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/13388760
Created attachment 155736 [details] Patch
Here is the corresponding chromium CR for removing redundant code from webkit_glue - https://chromiumcodereview.appspot.com/10829099/
Comment on attachment 155736 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=155736&action=review Basically looks good. Added a few comment. > Source/WebCore/testing/Internals.cpp:1137 > + return -1; Could you throw an exception rather than returning this? I think it could break compatibility (or can be compatible with tiny change.) > Source/WebCore/testing/Internals.cpp:1145 > + return String(); Ditto. > Source/WebCore/testing/Internals.cpp:1153 > + return String(); Ditto.
Created attachment 155762 [details] Patch
Thanks Morrita for review. I have updated the Internals APIs with throwing exception codes. As well as added exception codes for previously migrated ones. Please review.
Comment on attachment 155762 [details] Patch Attachment 155762 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/13418108
Created attachment 155777 [details] Patch
Comment on attachment 155777 [details] Patch Attachment 155777 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/13417144
Created attachment 155783 [details] Patch
Created attachment 155786 [details] Patch
Comment on attachment 155786 [details] Patch Attachment 155786 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/13419096
Created attachment 155791 [details] Patch
Comment on attachment 155791 [details] Patch Attachment 155791 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/13410390
Comment on attachment 155791 [details] Patch Attachment 155791 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13403719 New failing tests: printing/page-break-avoid.html fast/forms/range/slider-delete-while-dragging-thumb.html printing/page-count-relayout-shrink.html printing/page-count-percentage-height.html printing/css2.1/page-break-after-000.html fast/loader/loadInProgress.html printing/numberOfPages.html printing/page-break-orphans-and-widows.html printing/page-break-always.html printing/no-content-empty-pages.html printing/page-break-after-avoid.html http/tests/security/script-crossorigin-loads-correctly.html printing/page-break-display-none.html printing/page-break-widows.html printing/pageNumerForElementById.html http/tests/xmlhttprequest/zero-length-response.html printing/page-count-layout-overflow.html fast/forms/range/slider-mouse-events.html printing/stretch-to-view-height.html fast/forms/range/slider-onchange-event.html printing/page-break-margin-collapsed.html fast/loader/unload-form-post-about-blank.html printing/page-break-inside-avoid.html printing/allowed-page-breaks.html printing/page-break-orphans.html printing/page-break-before-avoid.html
Created attachment 155878 [details] Archive of layout-test-results from gce-cr-linux-03 The attached test failures were seen while running run-webkit-tests on the chromium-ews. Bot: gce-cr-linux-03 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid
Created attachment 157455 [details] Patch
Comment on attachment 157455 [details] Patch Attachment 157455 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13471602 New failing tests: printing/page-break-avoid.html fast/forms/range/slider-delete-while-dragging-thumb.html printing/page-count-relayout-shrink.html printing/page-count-percentage-height.html fast/loader/loadInProgress.html printing/numberOfPages.html printing/page-break-orphans-and-widows.html printing/pageNumerForElementById.html printing/no-content-empty-pages.html printing/page-break-after-avoid.html fast/frames/cached-frame-counter.html printing/page-break-display-none.html printing/page-break-widows.html printing/page-break-always.html http/tests/xmlhttprequest/zero-length-response.html printing/page-count-layout-overflow.html platform/chromium/virtual/gpu/fast/canvas/webgl/shader-precision-format.html fast/forms/range/slider-mouse-events.html fast/canvas/webgl/shader-precision-format.html printing/stretch-to-view-height.html fast/forms/range/slider-onchange-event.html printing/page-break-margin-collapsed.html fast/loader/unload-form-post-about-blank.html printing/page-break-inside-avoid.html printing/allowed-page-breaks.html printing/page-break-orphans.html printing/page-break-before-avoid.html
Created attachment 157750 [details] Archive of layout-test-results from gce-cr-linux-02 The attached test failures were seen while running run-webkit-tests on the chromium-ews. Bot: gce-cr-linux-02 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid
Created attachment 162030 [details] Patch
Comment on attachment 162030 [details] Patch Attachment 162030 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/13739558
(In reply to comment #29) > (From update of attachment 162030 [details]) > Attachment 162030 [details] did not pass win-ews (win): > Output: http://queues.webkit.org/results/13739558 Weird error :( Don't know how came these unresolved symbols came in??
Created attachment 162177 [details] Patch
Comment on attachment 162177 [details] Patch Attachment 162177 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/13757503
Created attachment 162194 [details] Patch
Comment on attachment 162194 [details] Patch It's built! Let's land it!
Committed r127577: <http://trac.webkit.org/changeset/127577>