Bug 92735 - [DRT] LTC:: Move printing related APIs from LayoutTestController to Internals
Summary: [DRT] LTC:: Move printing related APIs from LayoutTestController to Internals
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Kaustubh Atrawalkar
URL:
Keywords:
Depends on:
Blocks: 87284
  Show dependency treegraph
 
Reported: 2012-07-31 02:53 PDT by Kaustubh Atrawalkar
Modified: 2012-09-05 04:36 PDT (History)
9 users (show)

See Also:


Attachments
WIP (64.46 KB, patch)
2012-07-31 02:55 PDT, Kaustubh Atrawalkar
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from gce-cr-linux-07 (619.75 KB, application/zip)
2012-07-31 04:37 PDT, WebKit Review Bot
no flags Details
Patch (95.39 KB, patch)
2012-07-31 04:56 PDT, Kaustubh Atrawalkar
no flags Details | Formatted Diff | Diff
Patch (95.33 KB, patch)
2012-08-01 00:34 PDT, Kaustubh Atrawalkar
no flags Details | Formatted Diff | Diff
Patch (97.05 KB, patch)
2012-08-01 02:26 PDT, Kaustubh Atrawalkar
no flags Details | Formatted Diff | Diff
Patch (97.93 KB, patch)
2012-08-01 04:10 PDT, Kaustubh Atrawalkar
no flags Details | Formatted Diff | Diff
Patch (98.10 KB, patch)
2012-08-01 05:13 PDT, Kaustubh Atrawalkar
no flags Details | Formatted Diff | Diff
Patch (97.94 KB, patch)
2012-08-01 05:27 PDT, Kaustubh Atrawalkar
no flags Details | Formatted Diff | Diff
Patch (98.21 KB, patch)
2012-08-01 06:05 PDT, Kaustubh Atrawalkar
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from gce-cr-linux-03 (362.88 KB, application/zip)
2012-08-01 13:51 PDT, WebKit Review Bot
no flags Details
Patch (98.01 KB, patch)
2012-08-09 05:45 PDT, Kaustubh Atrawalkar
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from gce-cr-linux-02 (417.22 KB, application/zip)
2012-08-10 09:55 PDT, WebKit Review Bot
no flags Details
Patch (93.40 KB, patch)
2012-09-04 06:34 PDT, Kaustubh Atrawalkar
no flags Details | Formatted Diff | Diff
Patch (94.47 KB, patch)
2012-09-05 00:49 PDT, Kaustubh Atrawalkar
no flags Details | Formatted Diff | Diff
Patch (93.77 KB, patch)
2012-09-05 02:26 PDT, Kaustubh Atrawalkar
morrita: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kaustubh Atrawalkar 2012-07-31 02:53:25 PDT
Implement numberOfPages, pageProperty & pageSizeAndMarginsInPixels in Internals and remove duplicated code from DumprenderTree & WebkitTestRunner.
Comment 1 Kaustubh Atrawalkar 2012-07-31 02:55:03 PDT
Created attachment 155479 [details]
WIP

WIP for getting Mac Win symbols for implemented APIs
Comment 2 Build Bot 2012-07-31 03:06:11 PDT
Comment on attachment 155479 [details]
WIP

Attachment 155479 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/13384906
Comment 3 Build Bot 2012-07-31 03:08:58 PDT
Comment on attachment 155479 [details]
WIP

Attachment 155479 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/13385853
Comment 4 Early Warning System Bot 2012-07-31 03:11:47 PDT
Comment on attachment 155479 [details]
WIP

Attachment 155479 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/13401337
Comment 5 Early Warning System Bot 2012-07-31 03:17:04 PDT
Comment on attachment 155479 [details]
WIP

Attachment 155479 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/13386793
Comment 6 WebKit Review Bot 2012-07-31 04:37:39 PDT
Comment on attachment 155479 [details]
WIP

Attachment 155479 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/13387736

New failing tests:
printing/css2.1/page-break-before-001.html
printing/page-count-relayout-shrink.html
printing/page-format-data.html
printing/css2.1/page-break-after-000.html
printing/css2.1/page-break-after-004.html
printing/page-rule-selection.html
printing/page-count-layout-overflow.html
printing/stretch-to-view-height.html
printing/css2.1/page-break-before-000.html
printing/page-count-percentage-height.html
printing/numberOfPages.html
printing/css2.1/page-break-after-003.html
printing/css2.1/page-break-after-001.html
printing/css2.1/page-break-before-002.html
Comment 7 WebKit Review Bot 2012-07-31 04:37:45 PDT
Created attachment 155492 [details]
Archive of layout-test-results from gce-cr-linux-07

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: gce-cr-linux-07  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid
Comment 8 Kaustubh Atrawalkar 2012-07-31 04:56:46 PDT
Created attachment 155496 [details]
Patch
Comment 9 Build Bot 2012-07-31 05:19:07 PDT
Comment on attachment 155496 [details]
Patch

Attachment 155496 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/13388760
Comment 10 Kaustubh Atrawalkar 2012-08-01 00:34:22 PDT
Created attachment 155736 [details]
Patch
Comment 11 Kaustubh Atrawalkar 2012-08-01 00:35:26 PDT
Here is the corresponding chromium CR for removing redundant code from webkit_glue - https://chromiumcodereview.appspot.com/10829099/
Comment 12 Hajime Morrita 2012-08-01 00:51:13 PDT
Comment on attachment 155736 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=155736&action=review

Basically looks good. Added a few comment.

> Source/WebCore/testing/Internals.cpp:1137
> +        return -1;

Could you throw an exception rather than returning this?
I think it could break compatibility (or can be compatible with tiny change.)

> Source/WebCore/testing/Internals.cpp:1145
> +        return String();

Ditto.

> Source/WebCore/testing/Internals.cpp:1153
> +        return String();

Ditto.
Comment 13 Kaustubh Atrawalkar 2012-08-01 02:26:05 PDT
Created attachment 155762 [details]
Patch
Comment 14 Kaustubh Atrawalkar 2012-08-01 02:29:49 PDT
Thanks Morrita for review. I have updated the Internals APIs with throwing exception codes. As well as added exception codes for previously migrated ones. Please review.
Comment 15 Build Bot 2012-08-01 02:42:24 PDT
Comment on attachment 155762 [details]
Patch

Attachment 155762 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/13418108
Comment 16 Kaustubh Atrawalkar 2012-08-01 04:10:19 PDT
Created attachment 155777 [details]
Patch
Comment 17 Build Bot 2012-08-01 04:24:28 PDT
Comment on attachment 155777 [details]
Patch

Attachment 155777 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/13417144
Comment 18 Kaustubh Atrawalkar 2012-08-01 05:13:05 PDT
Created attachment 155783 [details]
Patch
Comment 19 Kaustubh Atrawalkar 2012-08-01 05:27:11 PDT
Created attachment 155786 [details]
Patch
Comment 20 Build Bot 2012-08-01 05:52:28 PDT
Comment on attachment 155786 [details]
Patch

Attachment 155786 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/13419096
Comment 21 Kaustubh Atrawalkar 2012-08-01 06:05:38 PDT
Created attachment 155791 [details]
Patch
Comment 22 Build Bot 2012-08-01 06:19:09 PDT
Comment on attachment 155791 [details]
Patch

Attachment 155791 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/13410390
Comment 23 WebKit Review Bot 2012-08-01 13:51:49 PDT
Comment on attachment 155791 [details]
Patch

Attachment 155791 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/13403719

New failing tests:
printing/page-break-avoid.html
fast/forms/range/slider-delete-while-dragging-thumb.html
printing/page-count-relayout-shrink.html
printing/page-count-percentage-height.html
printing/css2.1/page-break-after-000.html
fast/loader/loadInProgress.html
printing/numberOfPages.html
printing/page-break-orphans-and-widows.html
printing/page-break-always.html
printing/no-content-empty-pages.html
printing/page-break-after-avoid.html
http/tests/security/script-crossorigin-loads-correctly.html
printing/page-break-display-none.html
printing/page-break-widows.html
printing/pageNumerForElementById.html
http/tests/xmlhttprequest/zero-length-response.html
printing/page-count-layout-overflow.html
fast/forms/range/slider-mouse-events.html
printing/stretch-to-view-height.html
fast/forms/range/slider-onchange-event.html
printing/page-break-margin-collapsed.html
fast/loader/unload-form-post-about-blank.html
printing/page-break-inside-avoid.html
printing/allowed-page-breaks.html
printing/page-break-orphans.html
printing/page-break-before-avoid.html
Comment 24 WebKit Review Bot 2012-08-01 13:51:54 PDT
Created attachment 155878 [details]
Archive of layout-test-results from gce-cr-linux-03

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: gce-cr-linux-03  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid
Comment 25 Kaustubh Atrawalkar 2012-08-09 05:45:19 PDT
Created attachment 157455 [details]
Patch
Comment 26 WebKit Review Bot 2012-08-10 09:55:04 PDT
Comment on attachment 157455 [details]
Patch

Attachment 157455 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/13471602

New failing tests:
printing/page-break-avoid.html
fast/forms/range/slider-delete-while-dragging-thumb.html
printing/page-count-relayout-shrink.html
printing/page-count-percentage-height.html
fast/loader/loadInProgress.html
printing/numberOfPages.html
printing/page-break-orphans-and-widows.html
printing/pageNumerForElementById.html
printing/no-content-empty-pages.html
printing/page-break-after-avoid.html
fast/frames/cached-frame-counter.html
printing/page-break-display-none.html
printing/page-break-widows.html
printing/page-break-always.html
http/tests/xmlhttprequest/zero-length-response.html
printing/page-count-layout-overflow.html
platform/chromium/virtual/gpu/fast/canvas/webgl/shader-precision-format.html
fast/forms/range/slider-mouse-events.html
fast/canvas/webgl/shader-precision-format.html
printing/stretch-to-view-height.html
fast/forms/range/slider-onchange-event.html
printing/page-break-margin-collapsed.html
fast/loader/unload-form-post-about-blank.html
printing/page-break-inside-avoid.html
printing/allowed-page-breaks.html
printing/page-break-orphans.html
printing/page-break-before-avoid.html
Comment 27 WebKit Review Bot 2012-08-10 09:55:13 PDT
Created attachment 157750 [details]
Archive of layout-test-results from gce-cr-linux-02

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: gce-cr-linux-02  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid
Comment 28 Kaustubh Atrawalkar 2012-09-04 06:34:17 PDT
Created attachment 162030 [details]
Patch
Comment 29 Build Bot 2012-09-04 07:28:50 PDT
Comment on attachment 162030 [details]
Patch

Attachment 162030 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/13739558
Comment 30 Kaustubh Atrawalkar 2012-09-04 07:33:04 PDT
(In reply to comment #29)
> (From update of attachment 162030 [details])
> Attachment 162030 [details] did not pass win-ews (win):
> Output: http://queues.webkit.org/results/13739558

Weird error :( Don't know how came these unresolved symbols came in??
Comment 31 Kaustubh Atrawalkar 2012-09-05 00:49:45 PDT
Created attachment 162177 [details]
Patch
Comment 32 Build Bot 2012-09-05 01:15:27 PDT
Comment on attachment 162177 [details]
Patch

Attachment 162177 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/13757503
Comment 33 Kaustubh Atrawalkar 2012-09-05 02:26:18 PDT
Created attachment 162194 [details]
Patch
Comment 34 Hajime Morrita 2012-09-05 03:51:41 PDT
Comment on attachment 162194 [details]
Patch

It's built! Let's land it!
Comment 35 Kaustubh Atrawalkar 2012-09-05 04:36:44 PDT
Committed r127577: <http://trac.webkit.org/changeset/127577>