Bug 92728 - DFG OSR exit profiling has unusual oversights
Summary: DFG OSR exit profiling has unusual oversights
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on:
Blocks: 92696
  Show dependency tree / graph
 
Reported: 2012-07-31 01:59 PDT by Filip Pizlo
Modified: 2012-07-31 11:48 PDT (History)
6 users (show)

See Also:

Attachments
the patch (3.87 KB, patch)
2012-07-31 02:03 PDT, Filip Pizlo 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2012-07-31 01:59:14 PDT 
- StructureTransitionWatchpoint doesn't record when it exits.

- OSR exit counting uses the wrong codeOrigin for forward speculations that appear at the very end of an inlined block.
Comment 1 Filip Pizlo 2012-07-31 02:03:26 PDT 
Created attachment 155468 [details]
the patch
Comment 2 Geoffrey Garen 2012-07-31 08:23:41 PDT 
Comment on attachment 155468 [details]
the patch

r=me
Comment 3 WebKit Review Bot 2012-07-31 11:48:37 PDT 
Comment on attachment 155468 [details]
the patch

Clearing flags on attachment: 155468

Committed r124230: <http://trac.webkit.org/changeset/124230>
Comment 4 WebKit Review Bot 2012-07-31 11:48:41 PDT 
All reviewed patches have been landed.  Closing bug.