WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
92715
Read tag names and attributes from the saved tokens in HTMLTreeBuilder::processEndTag(AtomicHTMLToken*)
https://bugs.webkit.org/show_bug.cgi?id=92715
Summary
Read tag names and attributes from the saved tokens in HTMLTreeBuilder::proce...
Kwang Yul Seo
Reported
2012-07-30 23:03:55 PDT
This is a follow-up patch for
r123577
. Changed oneBelowTop to oneBelowTopStackItem.
Attachments
Patch
(4.48 KB, patch)
2012-07-30 23:05 PDT
,
Kwang Yul Seo
abarth
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Kwang Yul Seo
Comment 1
2012-07-30 23:05:46 PDT
Created
attachment 155445
[details]
Patch
Adam Barth
Comment 2
2012-07-31 09:15:18 PDT
Comment on
attachment 155445
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=155445&action=review
> Source/WebCore/html/parser/HTMLConstructionSite.h:116 > - Element* oneBelowTop() const { return m_openElements.oneBelowTop(); } > + HTMLStackItem* oneBelowTopStackItem() const { return m_openElements.oneBelowTopStackItem(); }
You can also keep the same name since you're removing the old function. They types are incompatible, so it's not going to confuse anyone.
Kwang Yul Seo
Comment 3
2012-07-31 15:53:40 PDT
(In reply to
comment #2
)
> You can also keep the same name since you're removing the old function. They types are incompatible, so it's not going to confuse anyone.
Okay. I will keep the name.
Kwang Yul Seo
Comment 4
2012-07-31 16:00:40 PDT
Committed
r124262
: <
http://trac.webkit.org/changeset/124262
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug