Bug 92715 - Read tag names and attributes from the saved tokens in HTMLTreeBuilder::processEndTag(AtomicHTMLToken*)
Summary: Read tag names and attributes from the saved tokens in HTMLTreeBuilder::proce...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kwang Yul Seo
URL:
Keywords:
Depends on:
Blocks: 92057
  Show dependency treegraph
 
Reported: 2012-07-30 23:03 PDT by Kwang Yul Seo
Modified: 2012-07-31 16:00 PDT (History)
2 users (show)

See Also:


Attachments
Patch (4.48 KB, patch)
2012-07-30 23:05 PDT, Kwang Yul Seo
abarth: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kwang Yul Seo 2012-07-30 23:03:55 PDT
This is a follow-up patch for r123577. Changed oneBelowTop to oneBelowTopStackItem.
Comment 1 Kwang Yul Seo 2012-07-30 23:05:46 PDT
Created attachment 155445 [details]
Patch
Comment 2 Adam Barth 2012-07-31 09:15:18 PDT
Comment on attachment 155445 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=155445&action=review

> Source/WebCore/html/parser/HTMLConstructionSite.h:116
> -    Element* oneBelowTop() const { return m_openElements.oneBelowTop(); }
> +    HTMLStackItem* oneBelowTopStackItem() const { return m_openElements.oneBelowTopStackItem(); }

You can also keep the same name since you're removing the old function.  They types are incompatible, so it's not going to confuse anyone.
Comment 3 Kwang Yul Seo 2012-07-31 15:53:40 PDT
(In reply to comment #2)
> You can also keep the same name since you're removing the old function.  They types are incompatible, so it's not going to confuse anyone.

Okay. I will keep the name.
Comment 4 Kwang Yul Seo 2012-07-31 16:00:40 PDT
Committed r124262: <http://trac.webkit.org/changeset/124262>