Bug 92695 - Fix potential compile error on LocalFileSystem::deleteFileSystem
Summary: Fix potential compile error on LocalFileSystem::deleteFileSystem
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Taiju Tsuiki
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-07-30 17:27 PDT by Taiju Tsuiki
Modified: 2012-07-31 12:20 PDT (History)
2 users (show)

See Also:


Attachments
Patch (1.92 KB, patch)
2012-07-30 17:29 PDT, Taiju Tsuiki
no flags Details | Formatted Diff | Diff
Patch (2.22 KB, patch)
2012-07-31 10:22 PDT, Taiju Tsuiki
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Taiju Tsuiki 2012-07-30 17:27:22 PDT
The callback type in LocalFileSystem::deleteFileSystem arguments should AsyncFileSystemCallbacks, instead of ErrorCallback.
# Sorry, I contaminated with it a few weeks ago.
Comment 1 Taiju Tsuiki 2012-07-30 17:29:27 PDT
Created attachment 155407 [details]
Patch
Comment 2 Adam Barth 2012-07-31 09:12:44 PDT
Comment on attachment 155407 [details]
Patch

Ok.  Can you explain the change a bit more in the ChangeLog?  For example, which builds are broken and why the chromium build works.
Comment 3 Taiju Tsuiki 2012-07-31 10:22:28 PDT
Created attachment 155581 [details]
Patch
Comment 4 Taiju Tsuiki 2012-07-31 10:25:09 PDT
(In reply to comment #2)
> (From update of attachment 155407 [details])
> Ok.  Can you explain the change a bit more in the ChangeLog?  For example, which builds are broken and why the chromium build works.

Sure, I updated the ChangeLog.
Comment 5 Adam Barth 2012-07-31 11:52:23 PDT
Comment on attachment 155581 [details]
Patch

Thanks.
Comment 6 WebKit Review Bot 2012-07-31 12:20:47 PDT
Comment on attachment 155581 [details]
Patch

Clearing flags on attachment: 155581

Committed r124238: <http://trac.webkit.org/changeset/124238>
Comment 7 WebKit Review Bot 2012-07-31 12:20:50 PDT
All reviewed patches have been landed.  Closing bug.