Bug 92666 – Add a mechanism to dump the stack trace in case of a crash

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Template Framework

[Thiago Marcos P. Santos]

Unix based ports can make use of signal handlers to dump the stack trace in case of crashes. This is specially handy when a test fails on the bot without hitting an assertion. We might have a chance to see some insightful information on the bots.

[Thiago Marcos P. Santos]

Created attachment 155353 [details]
Patch

[Balazs Kelemen]

Comment on attachment 155353 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=155353&action=review

Informally LGTM, but I have some naming nits (informally) :)

> Source/WTF/wtf/Assertions.cpp:371
> +static void setupSignalHandlers(void (*handler)(int))

setupSignalHandlersForFatalErrors ?

> Source/WTF/wtf/Assertions.cpp:391
> +void WTFReportBacktraceOnCrash()
> +{

This should have a different name otherwise it's hard to guess what it does at the call site.
WTFSetupReportBactraceOnCrash maybe.

[Thiago Marcos P. Santos]

Created attachment 155532 [details]
Patch

Thanks for the informal review. I'm using now the 'install' prefix like in webInstallExceptionHandler. The function is called xxxxHook to leave it open to non-POSIX ports to implement similar functionality not necessary using signal handlers.

[Csaba Osztrogonác]

Comment on attachment 155532 [details]
Patch

LGTM, r=me.

[WebKit Review Bot]

Comment on attachment 155532 [details]
Patch

Clearing flags on attachment: 155532

Committed r124215: <http://trac.webkit.org/changeset/124215>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.