Bug 92664 - After r123895, new-run-webkit-tests can fail with TypeError when a test crashes
Summary: After r123895, new-run-webkit-tests can fail with TypeError when a test crashes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Michael Saboff
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-07-30 11:41 PDT by Michael Saboff
Modified: 2012-07-30 11:55 PDT (History)
1 user (show)

See Also:


Attachments
Patch (1.72 KB, patch)
2012-07-30 11:44 PDT, Michael Saboff
no flags Details | Formatted Diff | Diff
Patch (1.66 KB, patch)
2012-07-30 11:51 PDT, Dirk Pranke
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Saboff 2012-07-30 11:41:58 PDT
After http://trac.webkit.org/changeset/123895, I'm seeing the following Python traceback when a test crashes and the controller tries to gather the crash_logs.

TypeError raised: coercing to Unicode: need string or buffer, tuple found
11:27:31.413 73403     File "/Volumes/Data/slave/lion-debug-tests-wk2/build/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py", line 115, in run
11:27:31.414 73403       unexpected_result_count = manager.run(args)
11:27:31.414 73403     File "/Volumes/Data/slave/lion-debug-tests-wk2/build/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py", line 881, in run
11:27:31.414 73403       self._look_for_new_crash_logs(result_summary, start_time)
11:27:31.414 73403     File "/Volumes/Data/slave/lion-debug-tests-wk2/build/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py", line 964, in _look_for_new_crash_logs
11:27:31.414 73403       writer.write_crash_log(crash_log)
11:27:31.414 73403     File "/Volumes/Data/slave/lion-debug-tests-wk2/build/Tools/Scripts/webkitpy/layout_tests/controllers/test_result_writer.py", line 167, in write_crash_log
11:27:31.414 73403       self._write_text_file(filename, crash_log)
11:27:31.414 73403     File "/Volumes/Data/slave/lion-debug-tests-wk2/build/Tools/Scripts/webkitpy/layout_tests/controllers/test_result_writer.py", line 136, in _write_text_file
11:27:31.414 73403       self._filesystem.write_text_file(path, contents)
11:27:31.414 73403     File "/Volumes/Data/slave/lion-debug-tests-wk2/build/Tools/Scripts/webkitpy/common/system/filesystem.py", line 226, in write_text_file
11:27:31.414 73403       f.write(contents)
11:27:31.414 73403     File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/codecs.py", line 691, in write
11:27:31.415 73403       return self.writer.write(data)
11:27:31.415 73403     File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/codecs.py", line 351, in write
11:27:31.415 73403       data, consumed = self.encode(object, self.errors)
Failed to execute Tools/Scripts/new-run-webkit-tests at ./Tools/Scripts/run-webkit-tests line 124.
program finished with exit code 254

It looks like manager.py needs to be updated for r123895.
Comment 1 Michael Saboff 2012-07-30 11:44:04 PDT
Created attachment 155330 [details]
Patch
Comment 2 Dirk Pranke 2012-07-30 11:51:49 PDT
Created attachment 155333 [details]
Patch
Comment 3 Dirk Pranke 2012-07-30 11:55:30 PDT
Comment on attachment 155333 [details]
Patch

Clearing flags on attachment: 155333

Committed r124071: <http://trac.webkit.org/changeset/124071>
Comment 4 Dirk Pranke 2012-07-30 11:55:32 PDT
All reviewed patches have been landed.  Closing bug.