RESOLVED FIXED92650
Web Inspector: clang plugin for checking native memory instrumentation coverage 
https://bugs.webkit.org/show_bug.cgi?id=92650
Summary Web Inspector: clang plugin for checking native memory instrumentation coverage
Ilya Tikhonovsky
Reported 2012-07-30 08:12:08 PDT
This is the clang plugin for checking native memory instrumentation coverage. The idea: InspectorMemoryAgent traverses through instrumented objects and collects pointers and their sizes and types. It is doing that with help of reportMemoryUsage function that needs to be implemented in each, significant from native memory footprint point of view, WebCore class. This plugin checks that the list of class members is matching with the list of members reported in reportMemoryUsage function.
Attachments
Patch (18.96 KB, patch)
2012-07-30 08:18 PDT, Ilya Tikhonovsky 		yurys: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ilya Tikhonovsky
Comment 1 2012-07-30 08:18:15 PDT
Created attachment 155295 [details] Patch
Ilya Tikhonovsky
Comment 2 2012-07-30 08:46:55 PDT
Comment on attachment 155295 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=155295&action=review > Tools/clang/ReportMemoryUsagePlugin/ReportMemoryUsage.cpp:136 > + void CheckMembersCoverage(const CXXRecordDecl* instrumentedClass, const Strings& instrumentedMembers, SourceLocation location) checkMembersCoverage
Yury Semikhatsky
Comment 3 2012-08-02 03:31:03 PDT
Comment on attachment 155295 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=155295&action=review > Tools/clang/ReportMemoryUsagePlugin/Makefile:5 > +# cp -R <this directory> third_party/llvm/tools/clang/tools/report-memory-usage-plugin Please fix the comment. Also we probably need a more detailed description here on how to use the plugin.
Ilya Tikhonovsky
Comment 4 2012-08-03 01:05:07 PDT
Committed r124579: <http://trac.webkit.org/changeset/124579>
Note You need to log in before you can comment on or make changes to this bug.