Bug 92610 - Enable variables tests by default for chromium.
Summary: Enable variables tests by default for chromium.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Luke Macpherson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-07-29 21:41 PDT by Luke Macpherson
Modified: 2012-08-05 19:36 PDT (History)
4 users (show)

See Also:


Attachments
Patch (1.46 KB, patch)
2012-07-29 21:42 PDT, Luke Macpherson
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from gce-cr-linux-01 (469.39 KB, application/zip)
2012-07-30 01:18 PDT, WebKit Review Bot
no flags Details
Patch (1.34 KB, patch)
2012-07-30 23:49 PDT, Luke Macpherson
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Luke Macpherson 2012-07-29 21:41:30 PDT
Enable variables tests by default for chromium.
Comment 1 Luke Macpherson 2012-07-29 21:42:26 PDT
Created attachment 155208 [details]
Patch
Comment 2 WebKit Review Bot 2012-07-30 01:18:26 PDT
Comment on attachment 155208 [details]
Patch

Attachment 155208 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/13392278

New failing tests:
inspector/styles/variables/css-variables.html
Comment 3 WebKit Review Bot 2012-07-30 01:18:29 PDT
Created attachment 155230 [details]
Archive of layout-test-results from gce-cr-linux-01

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: gce-cr-linux-01  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid
Comment 4 Dimitri Glazkov (Google) 2012-07-30 09:44:25 PDT
Comment on attachment 155208 [details]
Patch

The inspector failure looks real. Is this because inspector tests run only on some platforms?
Comment 5 Luke Macpherson 2012-07-30 23:49:35 PDT
Created attachment 155449 [details]
Patch
Comment 6 Luke Macpherson 2012-07-30 23:51:41 PDT
Looks like the inspector test has been broken (unsurprising, since it hasn't been running by default). I'll flip it on in a later patch along, but right now I want these on ASAP to prevent other breakage from setting in.
Comment 7 WebKit Review Bot 2012-08-05 19:36:10 PDT
Comment on attachment 155449 [details]
Patch

Clearing flags on attachment: 155449

Committed r124726: <http://trac.webkit.org/changeset/124726>
Comment 8 WebKit Review Bot 2012-08-05 19:36:14 PDT
All reviewed patches have been landed.  Closing bug.