Bug 92607 - Make fast/forms/resources/live-pseudo-selectors.css to be succeeded with when applying :read-only/:read-write selectors to all elements
Summary: Make fast/forms/resources/live-pseudo-selectors.css to be succeeded with when...
Status: RESOLVED DUPLICATE of bug 92602
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: yosin
URL:
Keywords:
Depends on:
Blocks: 92602
  Show dependency treegraph
 
Reported: 2012-07-29 21:18 PDT by yosin
Modified: 2012-07-29 23:41 PDT (History)
1 user (show)

See Also:


Attachments
Patch 1 (5.80 KB, patch)
2012-07-29 22:09 PDT, yosin
no flags Details | Formatted Diff | Diff
Patch 2 (2.22 KB, patch)
2012-07-29 23:15 PDT, yosin
tkent: review-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description yosin 2012-07-29 21:18:45 PDT
The test select-live-pseudo-selectors.html uses same CSS attribute for non-mutually exclusive pseudo selectors. There is no priority for CSS pseudo class selectors. We should use same CSS attribute for mutually exclusive pseudo selectors.
Comment 1 yosin 2012-07-29 22:09:35 PDT
Created attachment 155210 [details]
Patch 1
Comment 2 yosin 2012-07-29 22:11:24 PDT
Comment on attachment 155210 [details]
Patch 1

Could you review this patch?
Thanks in advance.
Comment 3 Kent Tamura 2012-07-29 22:27:52 PDT
Comment on attachment 155210 [details]
Patch 1

View in context: https://bugs.webkit.org/attachment.cgi?id=155210&action=review

> LayoutTests/ChangeLog:11
> +          - Restricts :read-only select to input and textarea elements for
> +            avoiding unexpected CSS attribute changes

I don't understand this paragraph.
- What is 'CSS attribute'? Do you mean CSS property?
- Why applying :read-only to <select> should be avoided.

> LayoutTests/ChangeLog:14
> +          - Use CSS color attribute for :read-only pseudo selector for avoiding
> +            unspecified behavior when both elements matching :read-only and
> +            :invalid/:valid selectors.

Is it really unspecified?  I guess CSS has deterministic rules for such cases.
Comment 4 yosin 2012-07-29 22:55:58 PDT
When we apply :read-only/:read-write selectors all elements, fast/forms/select-live-pseudo-selectors.html failed at background color difference when "option" elements matched to both :read-only and :invalid/:valid.
Comment 5 Kent Tamura 2012-07-29 23:14:58 PDT
(In reply to comment #4)
> When we apply :read-only/:read-write selectors all elements, fast/forms/select-live-pseudo-selectors.html failed at background color difference when "option" elements matched to both :read-only and :invalid/:valid.

Would you explain more please? What test case in select-live-pseudo-selectors.html fails?
"option" never matches to :invalid and :valid. Your explanation is confusing.
Comment 6 yosin 2012-07-29 23:15:57 PDT
Created attachment 155212 [details]
Patch 2
Comment 7 yosin 2012-07-29 23:18:39 PDT
Comment on attachment 155212 [details]
Patch 2

Could you review this patch?
Thanks in advance.

= Changes since the last patch =
* The changes is only in live-pseudo-selectors.css
** Revert {input,textarea}-live-pseudo-selectors{.html,-expected.txt}
* Update ChangeLog
Comment 8 Kent Tamura 2012-07-29 23:38:18 PDT
Comment on attachment 155212 [details]
Patch 2

View in context: https://bugs.webkit.org/attachment.cgi?id=155212&action=review

> LayoutTests/ChangeLog:16
> +        When we don't do this, select-live-pseudo-selectors.html renders background
> +        of select element as background color specified in :read-only selector
> +        instead of background color specified in :invalid or :valid.

ok, I understand the intention of this change now.
It was hard to understand the benefit of this change to me. If this change was made at the same time as the improvement of :read-only/:read-write, the benefit would be clear.
I don't think we need to commit this prior to the :read-only/:read-write improvement. You just change it when you needed. This change is small enough.
Comment 9 yosin 2012-07-29 23:41:30 PDT
I'll merge this change to bug 92602.

*** This bug has been marked as a duplicate of bug 92602 ***