Bug 92575 – run-perf-tests should generate a results page

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Ryosuke Niwa]

Right now, run-perf-tests doesn't provide a results page to view results.
Given that one of common workflow is to performance tests before and after applying a patch and comparing results,
run-perf-tests should generate a results page, and ideally provide a way to compare results from different runs.

[Ryosuke Niwa]

Created attachment 155120 [details]
Screenshot of current results.html

[Ryosuke Niwa]

Created attachment 155121 [details]
Patch

[Ryosuke Niwa]

Created attachment 155123 [details]
Sample results page

[Ryosuke Niwa]

Created attachment 155124 [details]
Use the same filename as the output JSON

[Ryosuke Niwa]

Dear reviewers: the patch is actually quite small. It's bloated by the flot and flot.fillbetween.

[WebKit Review Bot]

Attachment 155124 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'PerformanceTests/ChangeLog', u'Performance..." exit_code: 1
Tools/ChangeLog:15:  Line contains tab character.  [whitespace/tab] [5]
Tools/ChangeLog:18:  Line contains tab character.  [whitespace/tab] [5]
Tools/ChangeLog:19:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 3 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Ryosuke Niwa]

Created attachment 155125 [details]
Removed tabs

[Ryosuke Niwa]

Note that a natural follow up patch to this will be giving a default JSON output path, and then have run-perf-tests open the results page at the end like run-webkit-tests does when there are failures.

[Eric Seidel (no email)]

Comment on attachment 155125 [details]
Removed tabs

I mean, we could easily have a resources/ directory for the results template, instead of inlining the minimize script.  But this is also OK for now.  run-perf-tests could even inline the scripts into the HTML if that were necessary.

[Ryosuke Niwa]

Thanks for the review.

(In reply to comment #9)
> (From update of attachment 155125 [details])
> I mean, we could easily have a resources/ directory for the results template, instead of inlining the minimize script.

My intention is to use this infrastructure for perf. EWS so being able to upload to Bugzilla without having to zip is quite important.

> But this is also OK for now.  run-perf-tests could even inline the scripts into the HTML if that were necessary.

Yes, that's what we're doing here. We inline all scripts and JSON into the results page.

[Ryosuke Niwa]

Committed r123985: <http://trac.webkit.org/changeset/123985>