Bug 92570 - [Chromium] Web Inspector: Win Dbg tests timing out (r123556 or r123560?)
Summary: [Chromium] Web Inspector: Win Dbg tests timing out (r123556 or r123560?)
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Feldman
Depends on:
Reported: 2012-07-27 22:04 PDT by Peter Kasting
Modified: 2012-08-03 14:19 PDT (History)
18 users (show)

See Also:

Patch (2.53 KB, patch)
2012-07-30 11:50 PDT, Kenneth Russell
no flags Details | Formatted Diff | Diff
Patch for landing (2.57 KB, patch)
2012-08-03 11:46 PDT, Kenneth Russell
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Peter Kasting 2012-07-27 22:04:22 PDT
At least the following tests all began timing out on the Chromium Windows debug canary bot at the same time:

inspector/debugger/dom-breakpoints.html (consistently)
inspector/timeline/timeline-network-received-data.html (usually)
inspector/timeline/timeline-start-time.html (sometimes)

The regression range is WebKit r123556-r123563: http://trac.webkit.org/log/?verbose=on&rev=123563&stop_rev=123556
Or Chromium r148262-148277: http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog.html?url=/trunk/src&mode=html&range=148277:148262

See flakiness dashboard link: http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=inspector%2Fdebugger%2Fdom-breakpoints.html%2Cinspector%2Ftimeline%2Ftimeline-network-received-data.html%2Cinspector%2Ftimeline%2Ftimeline-start-time.html

The Chromium commits look harmless to me.  The most obvious culprits seem like http://trac.webkit.org/changeset/123556 and http://trac.webkit.org/changeset/123560 .  CCed those patch authors.

Sending to pfeldman for initial triage, anyone else who knows the area feel free to take.
Comment 1 Kenneth Russell 2012-07-30 11:50:52 PDT
Created attachment 155331 [details]
Comment 2 Kenneth Russell 2012-07-30 11:51:45 PDT
I can believe that my patch http://trac.webkit.org/changeset/123556 could be the culprit. Here's a patch that should avoid having it affect these Inspector tests; shall we land this and see whether it clears up the timeouts?
Comment 3 Pavel Feldman 2012-08-02 11:53:01 PDT
Comment on attachment 155331 [details]

Do you have anyone to stamp this change? I can do that in case it is safe and you provide a brief explanation on why it is so. Thanks.
Comment 4 Kenneth Russell 2012-08-02 16:47:51 PDT
It restricts the earlier heuristics which force full GCs to only apply to pages using WebGL, not pages using 2D canvas contexts. This is sufficient for our needs at the moment, and I think will clear up the Inspector timeouts if those pages are using 2D canvas.
Comment 5 WebKit Review Bot 2012-08-02 23:10:23 PDT
Comment on attachment 155331 [details]

Rejecting attachment 155331 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:

Parsed 2 diffs from patch file(s).
patching file Source/WebCore/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Source/WebCore/bindings/v8/custom/V8HTMLCanvasElementCustom.cpp
Hunk #1 FAILED at 87.
1 out of 1 hunk FAILED -- saving rejects to file Source/WebCore/bindings/v8/custom/V8HTMLCanvasElementCustom.cpp.rej

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Pavel Feld..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue/

Full output: http://queues.webkit.org/results/13424550
Comment 6 Kenneth Russell 2012-08-03 11:46:18 PDT
Created attachment 156426 [details]
Patch for landing
Comment 7 WebKit Review Bot 2012-08-03 14:19:52 PDT
Comment on attachment 156426 [details]
Patch for landing

Clearing flags on attachment: 156426

Committed r124653: <http://trac.webkit.org/changeset/124653>
Comment 8 WebKit Review Bot 2012-08-03 14:19:58 PDT
All reviewed patches have been landed.  Closing bug.