Bug 92564 – Reset the set of "seen" plugins when the main frame load is committed.

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Jer Noble]

Reset the set of "seen" plugins when the main frame load is committed.

[Jer Noble]

Created attachment 155095 [details]
Patch

[Jer Noble]

Created attachment 155097 [details]
Patch

Fixed compile error.

[Anders Carlsson]

Comment on attachment 155097 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=155097&action=review

> Source/WebCore/loader/FrameLoader.cpp:3188
> +    if (isLoadingMainFrame())

I think this check should be

if (m_frame->page() && m_frame == m_frame->page()->mainFrame())

[Jer Noble]

(In reply to comment #3)
> (From update of attachment 155097 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=155097&action=review
> 
> > Source/WebCore/loader/FrameLoader.cpp:3188
> > +    if (isLoadingMainFrame())
> 
> I think this check should be
> 
> if (m_frame->page() && m_frame == m_frame->page()->mainFrame())

The isLoadingMainFrame() function should do basically that:

bool FrameLoader::isLoadingMainFrame() const
{
    Page* page = m_frame->page();
    return page && m_frame == page->mainFrame();
}

[Jer Noble]

Committed r123942: <http://trac.webkit.org/changeset/123942>