Bug 92564 - Reset the set of "seen" plugins when the main frame load is committed.
Summary: Reset the set of "seen" plugins when the main frame load is committed.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-07-27 17:24 PDT by Jer Noble
Modified: 2012-07-27 17:41 PDT (History)
4 users (show)

See Also:


Attachments
Patch (2.64 KB, patch)
2012-07-27 17:27 PDT, Jer Noble
no flags Details | Formatted Diff | Diff
Patch (2.64 KB, patch)
2012-07-27 17:31 PDT, Jer Noble
andersca: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2012-07-27 17:24:03 PDT
Reset the set of "seen" plugins when the main frame load is committed.
Comment 1 Jer Noble 2012-07-27 17:27:52 PDT
Created attachment 155095 [details]
Patch
Comment 2 Jer Noble 2012-07-27 17:31:03 PDT
Created attachment 155097 [details]
Patch

Fixed compile error.
Comment 3 Anders Carlsson 2012-07-27 17:33:15 PDT
Comment on attachment 155097 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=155097&action=review

> Source/WebCore/loader/FrameLoader.cpp:3188
> +    if (isLoadingMainFrame())

I think this check should be

if (m_frame->page() && m_frame == m_frame->page()->mainFrame())
Comment 4 Jer Noble 2012-07-27 17:36:54 PDT
(In reply to comment #3)
> (From update of attachment 155097 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=155097&action=review
> 
> > Source/WebCore/loader/FrameLoader.cpp:3188
> > +    if (isLoadingMainFrame())
> 
> I think this check should be
> 
> if (m_frame->page() && m_frame == m_frame->page()->mainFrame())

The isLoadingMainFrame() function should do basically that:

bool FrameLoader::isLoadingMainFrame() const
{
    Page* page = m_frame->page();
    return page && m_frame == page->mainFrame();
}
Comment 5 Jer Noble 2012-07-27 17:41:32 PDT
Committed r123942: <http://trac.webkit.org/changeset/123942>