RESOLVED FIXED Bug 92551
[Qt] [WK1] Spaces missing in output of fast/forms/mailto/advanced-{get,put}.html 
https://bugs.webkit.org/show_bug.cgi?id=92551
Summary [Qt] [WK1] Spaces missing in output of fast/forms/mailto/advanced-{get,put}.html
Caio Marcelo de Oliveira Filho
Reported 2012-07-27 14:57:58 PDT
The last line of those tests are expected to have some trailing spaces. Works in Qt WK2 but not with WK1.
Attachments
Patch (11.15 KB, patch)
2012-09-17 11:21 PDT, Marcelo Lira 		no flags
DetailsFormatted DiffDiff
Patch (8.13 KB, patch)
2012-09-17 11:52 PDT, Marcelo Lira 		no flags
DetailsFormatted DiffDiff
Patch (9.13 KB, patch)
2012-09-19 14:08 PDT, Marcelo Lira 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Marcelo Lira
Comment 1 2012-09-17 11:21:03 PDT
The problem here is that the text input boxes are rendered differently in chromium and qt/gtk/efl, causing the text dump to also differ. There are 4 adjacent input boxes in a page 800 pixel wide, the width of these inputs is unspecified, as it should since this is unrelated to purpose of the test, and left for the port to decide. Chromium puts the four in the same line, qt/gtk/efl breaks the line before the fourth input, causing an extra space to appear in the text dump. A fix to this test consists in just putting a <br> after each input element, which will ensure the text dumps will be identical in all platforms, eliminating the need for special expected files.
Marcelo Lira
Comment 2 2012-09-17 11:21:54 PDT
Created attachment 164421 [details] Patch
Caio Marcelo de Oliveira Filho
Comment 3 2012-09-17 11:31:14 PDT
Comment on attachment 164421 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=164421&action=review Nice catch! I have a suggestion. > LayoutTests/ChangeLog:19 > + A fix to this test consists in just putting a <br> after each > + input element, which will ensure the text dumps will be identical in all > + platforms, eliminating the need for special expected files. I think you could instead set the width of the inputs to 100px or something like that instead. This would avoid all the empty lines in the expected result, which are simply noise.
Marcelo Lira
Comment 4 2012-09-17 11:52:10 PDT
Created attachment 164429 [details] Patch
Caio Marcelo de Oliveira Filho
Comment 5 2012-09-17 12:03:15 PDT
Comment on attachment 164429 [details] Patch LGTM.
WebKit Review Bot
Comment 6 2012-09-19 13:50:51 PDT
Comment on attachment 164429 [details] Patch Rejecting attachment 164429 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: /mailto/advanced-get-expected.txt rm 'LayoutTests/platform/qt-5.0-wk2/fast/forms/mailto/advanced-get-expected.txt' patching file LayoutTests/platform/qt-5.0-wk2/fast/forms/mailto/advanced-put-expected.txt rm 'LayoutTests/platform/qt-5.0-wk2/fast/forms/mailto/advanced-put-expected.txt' patching file LayoutTests/platform/qt-mac/Skipped Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Adam Barth']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue Full output: http://queues.webkit.org/results/13897640
Marcelo Lira
Comment 7 2012-09-19 14:08:30 PDT
Created attachment 164776 [details] Patch
Marcelo Lira
Comment 8 2012-09-19 15:11:49 PDT
Comment on attachment 164776 [details] Patch This is just a rebase of the previous patch, already reviewed by Adam Barth.
WebKit Review Bot
Comment 9 2012-09-20 05:05:34 PDT
Comment on attachment 164776 [details] Patch Clearing flags on attachment: 164776 Committed r129120: <http://trac.webkit.org/changeset/129120>
WebKit Review Bot
Comment 10 2012-09-20 05:05:40 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.