Bug 92549 - chromium win compile broken after removing webkit.py
Summary: chromium win compile broken after removing webkit.py
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dirk Pranke
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-07-27 14:44 PDT by Dirk Pranke
Modified: 2012-07-30 19:57 PDT (History)
8 users (show)

See Also:

Attachments
Patch (3.07 KB, patch)
2012-07-27 14:46 PDT, Dirk Pranke 		no flags Details | Formatted Diff | Diff
Patch (2.88 KB, patch)
2012-07-30 17:27 PDT, Dirk Pranke 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Pranke 2012-07-27 14:44:59 PDT 
chromium win compile broken after removing webkit.py
Comment 1 Dirk Pranke 2012-07-27 14:46:55 PDT 
Created attachment 155053 [details]
Patch
Comment 2 Dirk Pranke 2012-07-27 15:42:58 PDT 
filed https://code.google.com/p/chromium/issues/detail?id=139426 for the problem with browser_tests.isolate (a file in chromium) listing files in webkit directly ...
Comment 3 Adam Barth 2012-07-27 15:58:52 PDT 
I don't we should accommodate folks who try to use webkitpy from outside svn.webkit.org.  We've been very clear from the beginning that webkitpy does not have a public API and attempts to use it from outside svn.webkit.org will break without notice.
Comment 4 Dirk Pranke 2012-07-27 15:59:54 PDT 
Comment on attachment 155053 [details]
Patch

I land-cowboyed this but I guess it didn't update the bug (and I forgot to --no-review it) ... 

http://trac.webkit.org/changeset/123918
Comment 5 Dirk Pranke 2012-07-27 16:00:19 PDT 
(In reply to comment #3)
> I don't we should accommodate folks who try to use webkitpy from outside svn.webkit.org.  We've been very clear from the beginning that webkitpy does not have a public API and attempts to use it from outside svn.webkit.org will break without notice.

See the comment I just left on the chromium bug; he's not trying to use webkitpy, he's trying to run NRWT.
Comment 6 Dirk Pranke 2012-07-27 16:01:11 PDT 
now, how we're approaching the "sparse checkout" / isolate problem, and how it should interact w/ webkit, on the other hand, is something worth discussing.
Comment 7 Adam Barth 2012-07-27 16:11:15 PDT 
I commented in the Chromium bug.  The summary is that the existence of webkitpy is an implementation detail of WebKit and any mention of webkitpy outside svn.webkit.org can and will be broken without notice.
Comment 8 Dirk Pranke 2012-07-30 17:25:40 PDT 
i believe maruel has fixed the downstream error, so I'm going to remove the stub now ...
Comment 9 Dirk Pranke 2012-07-30 17:27:14 PDT 
Created attachment 155406 [details]
Patch
Comment 10 Dirk Pranke 2012-07-30 18:18:16 PDT 
rubber stamp, anyone?
Comment 11 WebKit Review Bot 2012-07-30 19:57:09 PDT 
Comment on attachment 155406 [details]
Patch

Clearing flags on attachment: 155406

Committed r124158: <http://trac.webkit.org/changeset/124158>
Comment 12 WebKit Review Bot 2012-07-30 19:57:14 PDT 
All reviewed patches have been landed.  Closing bug.