RESOLVED FIXED 92549
chromium win compile broken after removing webkit.py 
https://bugs.webkit.org/show_bug.cgi?id=92549
Summary chromium win compile broken after removing webkit.py
Dirk Pranke
Reported 2012-07-27 14:44:59 PDT
chromium win compile broken after removing webkit.py
Attachments
Patch (3.07 KB, patch)
2012-07-27 14:46 PDT, Dirk Pranke 		no flags
DetailsFormatted DiffDiff
Patch (2.88 KB, patch)
2012-07-30 17:27 PDT, Dirk Pranke 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Dirk Pranke
Comment 1 2012-07-27 14:46:55 PDT
Created attachment 155053 [details] Patch
Dirk Pranke
Comment 2 2012-07-27 15:42:58 PDT
filed https://code.google.com/p/chromium/issues/detail?id=139426 for the problem with browser_tests.isolate (a file in chromium) listing files in webkit directly ...
Adam Barth
Comment 3 2012-07-27 15:58:52 PDT
I don't we should accommodate folks who try to use webkitpy from outside svn.webkit.org. We've been very clear from the beginning that webkitpy does not have a public API and attempts to use it from outside svn.webkit.org will break without notice.
Dirk Pranke
Comment 4 2012-07-27 15:59:54 PDT
Comment on attachment 155053 [details] Patch I land-cowboyed this but I guess it didn't update the bug (and I forgot to --no-review it) ... http://trac.webkit.org/changeset/123918
Dirk Pranke
Comment 5 2012-07-27 16:00:19 PDT
(In reply to comment #3) > I don't we should accommodate folks who try to use webkitpy from outside svn.webkit.org. We've been very clear from the beginning that webkitpy does not have a public API and attempts to use it from outside svn.webkit.org will break without notice. See the comment I just left on the chromium bug; he's not trying to use webkitpy, he's trying to run NRWT.
Dirk Pranke
Comment 6 2012-07-27 16:01:11 PDT
now, how we're approaching the "sparse checkout" / isolate problem, and how it should interact w/ webkit, on the other hand, is something worth discussing.
Adam Barth
Comment 7 2012-07-27 16:11:15 PDT
I commented in the Chromium bug. The summary is that the existence of webkitpy is an implementation detail of WebKit and any mention of webkitpy outside svn.webkit.org can and will be broken without notice.
Dirk Pranke
Comment 8 2012-07-30 17:25:40 PDT
i believe maruel has fixed the downstream error, so I'm going to remove the stub now ...
Dirk Pranke
Comment 9 2012-07-30 17:27:14 PDT
Created attachment 155406 [details] Patch
Dirk Pranke
Comment 10 2012-07-30 18:18:16 PDT
rubber stamp, anyone?
WebKit Review Bot
Comment 11 2012-07-30 19:57:09 PDT
Comment on attachment 155406 [details] Patch Clearing flags on attachment: 155406 Committed r124158: <http://trac.webkit.org/changeset/124158>
WebKit Review Bot
Comment 12 2012-07-30 19:57:14 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.