Bug 92548 - [BlackBerry] Use new LocaleHandler
Summary: [BlackBerry] Use new LocaleHandler
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Eli Fidler
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-07-27 14:34 PDT by Eli Fidler
Modified: 2012-07-27 21:30 PDT (History)
3 users (show)

See Also:


Attachments
Patch (5.78 KB, patch)
2012-07-27 14:44 PDT, Eli Fidler
no flags Details | Formatted Diff | Diff
Patch (4.43 KB, patch)
2012-07-27 14:45 PDT, Eli Fidler
no flags Details | Formatted Diff | Diff
Patch (4.28 KB, patch)
2012-07-27 15:25 PDT, Eli Fidler
no flags Details | Formatted Diff | Diff
Patch (4.18 KB, patch)
2012-07-27 19:13 PDT, Eli Fidler
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eli Fidler 2012-07-27 14:34:09 PDT
There's a new LocaleHandler API.
Comment 1 Eli Fidler 2012-07-27 14:44:29 PDT
Created attachment 155051 [details]
Patch
Comment 2 Eli Fidler 2012-07-27 14:45:30 PDT
Created attachment 155052 [details]
Patch
Comment 3 Yong Li 2012-07-27 14:51:43 PDT
Comment on attachment 155052 [details]
Patch

r+ with changelog and style error fixed
Comment 4 Eli Fidler 2012-07-27 15:25:38 PDT
Created attachment 155065 [details]
Patch
Comment 5 WebKit Review Bot 2012-07-27 16:31:06 PDT
Comment on attachment 155065 [details]
Patch

Rejecting attachment 155065 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
WebCore/platform/network/blackberry/ResourceRequestBlackBerry.cpp
Hunk #2 succeeded at 218 (offset -2 lines).
patching file Source/WebCore/platform/text/blackberry/TextBreakIteratorInternalICUBlackBerry.cpp
Hunk #1 FAILED at 19.
1 out of 1 hunk FAILED -- saving rejects to file Source/WebCore/platform/text/blackberry/TextBreakIteratorInternalICUBlackBerry.cpp.rej

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue/

Full output: http://queues.webkit.org/results/13375737
Comment 6 Eli Fidler 2012-07-27 19:13:38 PDT
Created attachment 155100 [details]
Patch
Comment 7 WebKit Review Bot 2012-07-27 21:30:24 PDT
Comment on attachment 155100 [details]
Patch

Clearing flags on attachment: 155100

Committed r123950: <http://trac.webkit.org/changeset/123950>
Comment 8 WebKit Review Bot 2012-07-27 21:30:28 PDT
All reviewed patches have been landed.  Closing bug.