Bug 92529 - Change constructor with explicit constructor in WebCore/Modules
Summary: Change constructor with explicit constructor in WebCore/Modules
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gyuyoung Kim
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-07-27 12:08 PDT by Gyuyoung Kim
Modified: 2012-07-27 18:24 PDT (History)
4 users (show)

See Also:


Attachments
Patch (22.87 KB, patch)
2012-07-27 12:11 PDT, Gyuyoung Kim
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gyuyoung Kim 2012-07-27 12:08:52 PDT
As a step to let *explicit* keyword add to constructors which have a parameter, *explicit* keyword is added to Source/WebCore/Modules in order to avoid implicit type conversion.
Comment 1 Gyuyoung Kim 2012-07-27 12:11:55 PDT
Created attachment 155013 [details]
Patch
Comment 2 Gyuyoung Kim 2012-07-27 12:12:42 PDT
This patch should pass all ews.
Comment 3 Chris Dumez 2012-07-27 12:17:51 PDT
Comment on attachment 155013 [details]
Patch

LGTM.
Comment 4 Kentaro Hara 2012-07-27 17:33:10 PDT
Comment on attachment 155013 [details]
Patch

Looks OK. Please land the patch when you can keep watching the tree so that we can roll it out if it breaks any build.
Comment 5 Gyuyoung Kim 2012-07-27 17:34:38 PDT
Sure, when win ews is passed, I will land this. Then, I start to watch buildbot trees. Thanks.
Comment 6 WebKit Review Bot 2012-07-27 18:24:14 PDT
Comment on attachment 155013 [details]
Patch

Clearing flags on attachment: 155013

Committed r123945: <http://trac.webkit.org/changeset/123945>
Comment 7 WebKit Review Bot 2012-07-27 18:24:19 PDT
All reviewed patches have been landed.  Closing bug.