Bug 92526 - Increase inline storage for JSFinalObjects by one
Summary: Increase inline storage for JSFinalObjects by one
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Hahnenberg
Depends on:
Reported: 2012-07-27 11:54 PDT by Mark Hahnenberg
Modified: 2012-07-27 12:29 PDT (History)
2 users (show)

See Also:

Patch (1.76 KB, patch)
2012-07-27 11:56 PDT, Mark Hahnenberg
ggaren: review+
Details | Formatted Diff | Diff
Benchmark results (18.88 KB, text/plain)
2012-07-27 11:58 PDT, Mark Hahnenberg
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Hahnenberg 2012-07-27 11:54:31 PDT
Now that we've removed the inheritorID from objects, we can increase our inline storage for JSFinalObjects on 64-bit platforms by 1.
Comment 1 Mark Hahnenberg 2012-07-27 11:56:16 PDT
Created attachment 155005 [details]
Comment 2 Mark Hahnenberg 2012-07-27 11:58:54 PDT
Created attachment 155006 [details]
Benchmark results

Looks like a slight win on v8-real (~7% on richards) and kraken (~2% on imaging-darkroom).
Comment 3 Geoffrey Garen 2012-07-27 12:12:52 PDT
Comment on attachment 155005 [details]


This is going to make our lives harder when we go back to shrink these objects later, since it will be harder to do so without causing a performance regression. :( I guess we'll need to fast-track being smart about predicting and/or responding to object size.
Comment 4 Mark Hahnenberg 2012-07-27 12:29:19 PDT
Committed r123905: <http://trac.webkit.org/changeset/123905>