Bug 92525 - [Chromium] Enable deferred canvas rendering with SkGPipe in DumpRenderTree
Summary: [Chromium] Enable deferred canvas rendering with SkGPipe in DumpRenderTree
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Justin Novosad
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-07-27 11:40 PDT by Justin Novosad
Modified: 2013-04-15 08:05 PDT (History)
8 users (show)

See Also:

Attachments
Patch (8.35 KB, patch)
2012-07-27 11:50 PDT, Justin Novosad 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from gce-cr-linux-08 (999.24 KB, application/zip)
2012-07-27 15:54 PDT, WebKit Review Bot 		no flags Details
Patch (4.89 KB, patch)
2012-08-01 13:20 PDT, Justin Novosad 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from gce-cr-linux-06 (538.27 KB, application/zip)
2012-08-01 14:47 PDT, WebKit Review Bot 		no flags Details
Archive of layout-test-results from gce-cr-linux-05 (573.39 KB, application/zip)
2012-08-01 15:48 PDT, WebKit Review Bot 		no flags Details
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Justin Novosad 2012-07-27 11:40:41 PDT 
[Chromium] Enable deferred canvas rendering with SkGPipe in DumpRenderTree
Comment 1 Justin Novosad 2012-07-27 11:50:17 PDT 
Created attachment 155003 [details]
Patch
Comment 2 Mike Reed 2012-07-27 11:55:32 PDT 
I isn't no reviewer, but seems right to me.
Comment 3 Justin Novosad 2012-07-27 14:06:14 PDT 
Putting this change on hold because the test expectation are in flux. skia r4817 addresses 15 of the 18 fails. I will wait for the next skia roll to come in and resubmit a patch with fresh expectations.
Comment 4 Kenneth Russell 2012-07-27 14:11:21 PDT 
Comment on attachment 155003 [details]
Patch

Patch looks fine modulo the coming test expectations updates. r=me
Comment 5 WebKit Review Bot 2012-07-27 15:54:02 PDT 
Comment on attachment 155003 [details]
Patch

Attachment 155003 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/13368814

New failing tests:
platform/chromium/virtual/gpu/fast/canvas/canvas-text-baseline.html
Comment 6 WebKit Review Bot 2012-07-27 15:54:07 PDT 
Created attachment 155077 [details]
Archive of layout-test-results from gce-cr-linux-08

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: gce-cr-linux-08  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid
Comment 7 Justin Novosad 2012-08-01 13:20:27 PDT 
Created attachment 155870 [details]
Patch
Comment 8 Stephen White 2012-08-01 13:23:02 PDT 
Comment on attachment 155870 [details]
Patch

Looks good, bots willing.  r=me
Comment 9 WebKit Review Bot 2012-08-01 14:47:10 PDT 
Comment on attachment 155870 [details]
Patch

Attachment 155870 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/13404570

New failing tests:
platform/chromium/virtual/gpu/fast/canvas/canvas-composite.html
platform/chromium/virtual/gpu/fast/canvas/image-object-in-canvas.html
platform/chromium/virtual/gpu/fast/canvas/canvas-composite-transformclip.html
Comment 10 WebKit Review Bot 2012-08-01 14:47:13 PDT 
Created attachment 155890 [details]
Archive of layout-test-results from gce-cr-linux-06

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: gce-cr-linux-06  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid
Comment 11 WebKit Review Bot 2012-08-01 15:48:30 PDT 
Comment on attachment 155870 [details]
Patch

Attachment 155870 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/13418313

New failing tests:
platform/chromium/virtual/gpu/fast/canvas/canvas-composite.html
platform/chromium/virtual/gpu/fast/canvas/image-object-in-canvas.html
platform/chromium/virtual/gpu/fast/canvas/canvas-composite-transformclip.html
Comment 12 WebKit Review Bot 2012-08-01 15:48:34 PDT 
Created attachment 155907 [details]
Archive of layout-test-results from gce-cr-linux-05

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: gce-cr-linux-05  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid