RESOLVED FIXED 92523
Build warning in CSSPrimitiveValueMappings.h when CSS_STICKY_POSITION is disabled 
https://bugs.webkit.org/show_bug.cgi?id=92523
Summary Build warning in CSSPrimitiveValueMappings.h when CSS_STICKY_POSITION is disa...
Chris Dumez
Reported 2012-07-27 11:36:38 PDT
We get the following build warning in CSSPrimitiveValueMappings.h when CSS_STICKY_POSITION is disabled: /home/chris/unencrypted/WebKit/Source/WebCore/css/CSSPrimitiveValueMappings.h:2022:12: warning: enumeration value ‘StickyPosition’ not handled in switch [-Wswitch]
Attachments
Patch (2.52 KB, patch)
2012-07-27 11:54 PDT, Chris Dumez 		simon.fraser: review-
simon.fraser: commit-queue-
DetailsFormatted DiffDiff
Patch (1.45 KB, patch)
2012-07-27 13:01 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2012-07-27 11:54:51 PDT
Created attachment 155004 [details] Patch
Simon Fraser (smfr)
Comment 2 2012-07-27 12:52:04 PDT
Comment on attachment 155004 [details] Patch Why did this warn? I don't want the ENABLE(CSS_STICKY_POSITION) to propagate into style/layout code.
Chris Dumez
Comment 3 2012-07-27 12:57:30 PDT
(In reply to comment #2) > (From update of attachment 155004 [details]) > Why did this warn? I don't want the ENABLE(CSS_STICKY_POSITION) to propagate into style/layout code. Well, alternatively, we can change move the #ifdef at Source/WebCore/css/CSSPrimitiveValueMappings.h:2022 so that it does not cover the StickyPosition case, only the code inside the "case".
Simon Fraser (smfr)
Comment 4 2012-07-27 12:59:12 PDT
Sorry, I see you pasted the warning. We should fix this in CSSPrimitiveValueMappings.h.
Chris Dumez
Comment 5 2012-07-27 13:01:28 PDT
Created attachment 155030 [details] Patch Second attempt.
WebKit Review Bot
Comment 6 2012-07-27 15:41:27 PDT
Comment on attachment 155030 [details] Patch Clearing flags on attachment: 155030 Committed r123928: <http://trac.webkit.org/changeset/123928>
WebKit Review Bot
Comment 7 2012-07-27 15:41:32 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.