Bug 92517 - [WK2] Fix build warning in WebEventConversion.cpp
Summary: [WK2] Fix build warning in WebEventConversion.cpp
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gyuyoung Kim
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-07-27 10:47 PDT by Gyuyoung Kim
Modified: 2012-07-27 12:03 PDT (History)
2 users (show)

See Also:

Attachments
Patch (1.43 KB, patch)
2012-07-27 10:56 PDT, Gyuyoung Kim 		no flags Details | Formatted Diff | Diff
Patch (1.46 KB, patch)
2012-07-27 11:11 PDT, Gyuyoung Kim 		no flags Details | Formatted Diff | Diff
Patch (1.46 KB, patch)
2012-07-27 11:12 PDT, Gyuyoung Kim 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gyuyoung Kim 2012-07-27 10:47:25 PDT 
It looks there is comparison build warning in WebEventConversion.cpp as below,

WebKit::WebKit2PlatformTouchEvent::WebKit2PlatformTouchEvent(const WebKit::WebTouchEvent&)’:
/home/gyuyoung/webkit/WebKit/Source/WebKit2/Shared/WebEventConversion.cpp:322:57: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
Comment 1 Gyuyoung Kim 2012-07-27 10:56:59 PDT 
Created attachment 154989 [details]
Patch
Comment 2 Chris Dumez 2012-07-27 11:02:37 PDT 
Comment on attachment 154989 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=154989&action=review

> Source/WebKit2/ChangeLog:3
> +        [Wk2] Fix build warning 

in WebEventConversion.cpp ?

> Source/WebKit2/Shared/WebEventConversion.cpp:322
> +        for (unsigned i = 0; i < webEvent.touchPoints().size(); ++i)

You should use size_t since this is the type returned by WTK::Vector::size()
Comment 3 Chris Dumez 2012-07-27 11:04:35 PDT 
Comment on attachment 154989 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=154989&action=review

>> Source/WebKit2/ChangeLog:3
>> +        [Wk2] Fix build warning 
> 
> in WebEventConversion.cpp ?

Also maybe "[WK2]"
Comment 4 Gyuyoung Kim 2012-07-27 11:11:09 PDT 
Created attachment 154990 [details]
Patch
Comment 5 Gyuyoung Kim 2012-07-27 11:12:56 PDT 
Created attachment 154991 [details]
Patch
Comment 6 Gyuyoung Kim 2012-07-27 11:13:34 PDT 
Patch is modified.
Comment 7 Chris Dumez 2012-07-27 11:16:18 PDT 
Comment on attachment 154991 [details]
Patch

LGTM. Thanks.
Comment 8 WebKit Review Bot 2012-07-27 12:03:26 PDT 
Comment on attachment 154991 [details]
Patch

Clearing flags on attachment: 154991

Committed r123903: <http://trac.webkit.org/changeset/123903>
Comment 9 WebKit Review Bot 2012-07-27 12:03:31 PDT 
All reviewed patches have been landed.  Closing bug.