Get some errors when compiling MemoryInfo.h.
Created attachment 154916 [details] Patch
Fixing the build error is critical, but I am not sure if the fix is correct. Looks like Eric and Adam are not in IRC. If you are confident about the fix, I can rubber-stamp it.
(In reply to comment #2) > Fixing the build error is critical, but I am not sure if the fix is correct. Looks like Eric and Adam are not in IRC. If you are confident about the fix, I can rubber-stamp it. This fix just moves "struct HeapInfo" to outside INSPECTOR #ifdefs. I first thought about moving the struct to a new file... Let's wait and see what Eric and Adam thinks about this.
(In reply to comment #3) > Let's wait and see what Eric and Adam thinks about this. They are asleep:) So we might want to land your patch or roll out the original patch. If you can watch the tree for a while, it would be OK to try to land it.
(In reply to comment #4) > (In reply to comment #3) > > Let's wait and see what Eric and Adam thinks about this. > > They are asleep:) So we might want to land your patch or roll out the original patch. If you can watch the tree for a while, it would be OK to try to land it. IMO is fine. Thanks.
(In reply to comment #5) > (In reply to comment #4) > > (In reply to comment #3) > > > Let's wait and see what Eric and Adam thinks about this. > > > > They are asleep:) So we might want to land your patch or roll out the original patch. If you can watch the tree for a while, it would be OK to try to land it. > > IMO is fine. Thanks. cq+?
Comment on attachment 154916 [details] Patch Clearing flags on attachment: 154916 Committed r123873: <http://trac.webkit.org/changeset/123873>
All reviewed patches have been landed. Closing bug.
Comment on attachment 154916 [details] Patch Thanks for the fix!