Bug 92493 - REGRESSION(r123856): Breaks the build when disabling inspector
Summary: REGRESSION(r123856): Breaks the build when disabling inspector
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Thiago Marcos P. Santos
URL:
Keywords:
Depends on:
Blocks: 80444
  Show dependency treegraph
 
Reported: 2012-07-27 05:01 PDT by Thiago Marcos P. Santos
Modified: 2012-07-27 11:14 PDT (History)
6 users (show)

See Also:


Attachments
Patch (2.47 KB, patch)
2012-07-27 05:49 PDT, Thiago Marcos P. Santos
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Thiago Marcos P. Santos 2012-07-27 05:01:46 PDT
Get some errors when compiling MemoryInfo.h.
Comment 1 Thiago Marcos P. Santos 2012-07-27 05:49:32 PDT
Created attachment 154916 [details]
Patch
Comment 2 Kentaro Hara 2012-07-27 06:08:34 PDT
Fixing the build error is critical, but I am not sure if the fix is correct. Looks like Eric and Adam are not in IRC. If you are confident about the fix, I can rubber-stamp it.
Comment 3 Thiago Marcos P. Santos 2012-07-27 06:26:05 PDT
(In reply to comment #2)
> Fixing the build error is critical, but I am not sure if the fix is correct. Looks like Eric and Adam are not in IRC. If you are confident about the fix, I can rubber-stamp it.

This fix just moves "struct HeapInfo" to outside INSPECTOR #ifdefs. I first thought about moving the struct to a new file...

Let's wait and see what Eric and Adam thinks about this.
Comment 4 Kentaro Hara 2012-07-27 06:28:15 PDT
(In reply to comment #3)
> Let's wait and see what Eric and Adam thinks about this.

They are asleep:) So we might want to land your patch or roll out the original patch. If you can watch the tree for a while, it would be OK to try to land it.
Comment 5 Thiago Marcos P. Santos 2012-07-27 06:40:59 PDT
(In reply to comment #4)
> (In reply to comment #3)
> > Let's wait and see what Eric and Adam thinks about this.
> 
> They are asleep:) So we might want to land your patch or roll out the original patch. If you can watch the tree for a while, it would be OK to try to land it.

IMO is fine. Thanks.
Comment 6 Thiago Marcos P. Santos 2012-07-27 06:41:32 PDT
(In reply to comment #5)
> (In reply to comment #4)
> > (In reply to comment #3)
> > > Let's wait and see what Eric and Adam thinks about this.
> > 
> > They are asleep:) So we might want to land your patch or roll out the original patch. If you can watch the tree for a while, it would be OK to try to land it.
> 
> IMO is fine. Thanks.

cq+?
Comment 7 WebKit Review Bot 2012-07-27 06:57:21 PDT
Comment on attachment 154916 [details]
Patch

Clearing flags on attachment: 154916

Committed r123873: <http://trac.webkit.org/changeset/123873>
Comment 8 WebKit Review Bot 2012-07-27 06:57:25 PDT
All reviewed patches have been landed.  Closing bug.
Comment 9 Adam Barth 2012-07-27 11:14:24 PDT
Comment on attachment 154916 [details]
Patch

Thanks for the fix!