WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
NEW
92491
Style checker is not strict enough in detecting of primary header for a .cpp file
https://bugs.webkit.org/show_bug.cgi?id=92491
Summary
Style checker is not strict enough in detecting of primary header for a .cpp ...
Mikhail Pozdnyakov
Reported
2012-07-27 04:51:48 PDT
Style checker is not strict enough in detecting of primary header for a .cpp file. This causes following problem: if a .cpp file does not have primary header but includes another header file having the name same as a substring of this .cpp file name, the following message is issued: " Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted. "
Attachments
Add attachment
proposed patch, testcase, etc.
Mikhail Pozdnyakov
Comment 1
2012-07-27 06:51:27 PDT
Little example: File ewk_view_loader_client.cpp does not have primary header. Adding '#include "ewk_view.h" ' causes an error message mentioned in previous comment because ewk_view.h is erroneously treated as a primary header.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug