Bug 92474 – DragController should ascertain dragClient to be non-null

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Vivek Galatage]

Page object should ascertain pageClients.dragClient to be non-null

[Vivek Galatage]

Created attachment 154882 [details]
Patch

[Vivek Galatage]

When enabled(DRAG_SUPPORT), the page object should ascertain pageClients.dragClient to be non-null. Page object goes on creating dragController with the given dragClient. The dragController assumes the dragClient being always available hence all the calls on dragClient are not checking for null value of m_client. So there are two options:

1. If the dragClient is still optional when ENABLE(DRAG_SUPPORT), then we should migrate the creation of dragController from Page::Page() constructor's initialization list inside the constructor body to create the controller only when a non-null dragClient is sent. a-la

if (pageClients.dragClient)
   m_dragController = DragController::create(this, pageClients.dragClient);

2. If this is mandatory when ENABLE(DRAG_SUPPORT), then we can simply put an ASSERT statement in Page::Page().

Please let me know your thoughts on the same.

[Vivek Galatage]

Created attachment 155026 [details]
Patch

[Tony Chang]

Comment on attachment 155026 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=155026&action=review

> Source/WebCore/ChangeLog:3
> +        Page object should ascertain pageClients.dragClient to be non-null

This description is no longer correct.  Otherwise, this change seems fine.

[Vivek Galatage]

Created attachment 155029 [details]
Patch

[WebKit Review Bot]

Comment on attachment 155029 [details]
Patch

Clearing flags on attachment: 155029

Committed r123927: <http://trac.webkit.org/changeset/123927>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.