Bug 92461 – Fix null pointer dereference when CSSParser::sinkFloatingValueList() returns null and is passed to storeVariableDeclaration().

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Luke Macpherson]

Fix null pointer dereference when CSSParser::sinkFloatingValueList() returns null and is passed to storeVariableDeclaration().

[Luke Macpherson]

Created attachment 154849 [details]
Patch

[Luke Macpherson]

Ping. Could someone please review?

[Eric Seidel (no email)]

Comment on attachment 154849 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=154849&action=review

> Source/WebCore/css/CSSParser.cpp:3019
> +    if (!value)
> +        return;

A comment here to explain the "why" might be helpful.

[Eric Seidel (no email)]

Comment on attachment 154849 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=154849&action=review

>> Source/WebCore/css/CSSParser.cpp:3019
>> +        return;
> 
> A comment here to explain the "why" might be helpful.

Something like:
// When CSSGrammar.y encounters an invalid/un-parseable declaration it passes null for the CSSParserValueList, just bail.

[Eric Seidel (no email)]

You don't have to make the comment, but if I were writing the code, I'd be tempted to explain the "why" as null checks are often mysterious as to their necessity or not.  This one you're claiming to be necessary based on how BISON behaves.

[Luke Macpherson]

Created attachment 156573 [details]
Patch for landing

[WebKit Review Bot]

Comment on attachment 156573 [details]
Patch for landing

Clearing flags on attachment: 156573

Committed r124723: <http://trac.webkit.org/changeset/124723>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.