WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
92458
Page object should ascertain EditorClient to be non-null
https://bugs.webkit.org/show_bug.cgi?id=92458
Summary
Page object should ascertain EditorClient to be non-null
Vivek Galatage
Reported
2012-07-26 22:28:27 PDT
Adding NULL checks for editor client within Page object
Attachments
Patch
(1.57 KB, patch)
2012-07-26 22:30 PDT
,
Vivek Galatage
no flags
Details
Formatted Diff
Diff
Patch
(1.22 KB, patch)
2012-07-26 23:15 PDT
,
Vivek Galatage
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Vivek Galatage
Comment 1
2012-07-26 22:30:11 PDT
Created
attachment 154842
[details]
Patch
Ryosuke Niwa
Comment 2
2012-07-26 22:41:45 PDT
Comment on
attachment 154842
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=154842&action=review
> Source/WebCore/ChangeLog:10 > + No new tests as no change in functionality. Just addition of check to avoid crash.
That's not true. If this can never cause a crash, then we don't have to do null check. If WebKit were to crash without these null checks, then there is a behavior change. Please try to come up with a test. It's okay if you could not come up with a test if it's too hard to do so but please don't say that there is no behavior change in WebKit, when there is one.
Vivek Galatage
Comment 3
2012-07-26 23:06:35 PDT
Changing the title of the bug as per the IRC discussion with rniwa.
Vivek Galatage
Comment 4
2012-07-26 23:15:48 PDT
Created
attachment 154851
[details]
Patch
WebKit Review Bot
Comment 5
2012-07-27 01:34:36 PDT
Comment on
attachment 154851
[details]
Patch Clearing flags on attachment: 154851 Committed
r123850
: <
http://trac.webkit.org/changeset/123850
>
WebKit Review Bot
Comment 6
2012-07-27 01:34:39 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug