Bug 92457 – [BlackBerry] Update sendRequestWithCredentials to use new getProxyAddress interface

• Status: RESOLVED
• Resolution: FIXED
• Component: Page Loading

[Joe Mason]

BlackBerry::Platform::Client::getProxyAddress has been updated to return "host:port", instead of having two separate functions for host and port.  Need to update NetworkJob to use the new API.

[Joe Mason]

Created attachment 154920 [details]
patch

[Yong Li]

Comment on attachment 154920 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=154920&action=review

> Source/WebCore/platform/network/blackberry/NetworkJob.cpp:690
> +        String proxyAddress = BlackBerry::Platform::Client::get()->getProxyAddress(newURL.string().utf8().data()).c_str();

Is latin1() any better than utf8() here?

[Yong Li]

seems String::ascii() is good to use now.

[Joe Mason]

Created attachment 154959 [details]
fixed utf8/ascii

Good catch. Changed to ascii

[Joe Mason]

Comment on attachment 154920 [details]
patch

Putting both the utf8 and ascii versions up for review. Let the reviewers fight it out.

[WebKit Review Bot]

Attachment 154959 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/ChangeLog:12:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Yong Li]

Comment on attachment 154959 [details]
fixed utf8/ascii

cancel committing for now. there is style error

[Joe Mason]

Created attachment 154965 [details]
ascii version with tab removed

Fixed style error

[WebKit Review Bot]

Comment on attachment 154959 [details]
fixed utf8/ascii

Cleared Yong Li's review+ from obsolete attachment 154959 [details] so that this bug does not appear in http://webkit.org/pending-commit.

[Joe Mason]

Comment on attachment 154920 [details]
patch

Clearing review flag as the other version is being committed

[WebKit Review Bot]

Comment on attachment 154965 [details]
ascii version with tab removed

Clearing flags on attachment: 154965

Committed r123890: <http://trac.webkit.org/changeset/123890>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.