Bug 92454 – [EFL] Return 0 when network is offline

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit EFL

[Gyuyoung Kim]

Network Info latest spec says 0 is returned when network is offline. r123769 modified to return *infinity value* when network is offiline.

[Gyuyoung Kim]

Created attachment 154832 [details]
Patch

[Chris Dumez]

Comment on attachment 154832 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=154832&action=review

> Source/WebCore/platform/efl/NetworkInfoProviderEfl.cpp:61
> +        return 0; // If network is offline, return 0.

if eeze_net_new() returns NULL, then it indicates that eth0 interface does not exist. The fact that the interface does not exist is difference from being offline. The user may be connected via another network interface. So, in my opinion, this means the bandwidth is unknown.

[Gyuyoung Kim]

(In reply to comment #2)
> (From update of attachment 154832 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=154832&action=review
> 
> > Source/WebCore/platform/efl/NetworkInfoProviderEfl.cpp:61
> > +        return 0; // If network is offline, return 0.
> 
> if eeze_net_new() returns NULL, then it indicates that eth0 interface does not exist. The fact that the interface does not exist is difference from being offline. The user may be connected via another network interface. So, in my opinion, this means the bandwidth is unknown.

Current implementation only supports ethernet. So, if eeze_net_new() returns NULL, it means there is no device and offline now. Of course, updated patch will support network regardless of wireless and ethernet. Then, we can consider if bandwidth is unknown.

[Gyuyoung Kim]

Kenneth, could you take a look ?

[Kenneth Rohde Christiansen]

Comment on attachment 154832 [details]
Patch

Shouldnt you leave an FIXME: for the future? or at least a note

[Gyuyoung Kim]

Created attachment 154962 [details]
Patch

[Gyuyoung Kim]

(In reply to comment #5)
> (From update of attachment 154832 [details])
> Shouldnt you leave an FIXME: for the future? or at least a note

I add an FIXME comment for now. Thanks.

[WebKit Review Bot]

Comment on attachment 154962 [details]
Patch

Clearing flags on attachment: 154962

Committed r123939: <http://trac.webkit.org/changeset/123939>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.