Bug 92452 - [chromium] Fix color matrix filter computation so that filters that don't need clamping are correctly detected as such
Summary: [chromium] Fix color matrix filter computation so that filters that don't nee...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antoine Labour
URL:
Keywords:
Depends on:
Blocks: 92453
  Show dependency treegraph
 
Reported: 2012-07-26 21:07 PDT by Antoine Labour
Modified: 2012-07-27 16:02 PDT (History)
5 users (show)

See Also:


Attachments
Patch (3.98 KB, patch)
2012-07-26 21:09 PDT, Antoine Labour
no flags Details | Formatted Diff | Diff
Patch for landing (3.94 KB, patch)
2012-07-27 14:28 PDT, Antoine Labour
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Antoine Labour 2012-07-26 21:07:58 PDT
[chromium] Fix color matrix filter computation so that filters that don't need clamping are correctly detected as such
Comment 1 Antoine Labour 2012-07-26 21:09:56 PDT
Created attachment 154828 [details]
Patch
Comment 2 Antoine Labour 2012-07-26 21:23:18 PDT
FYI, https://bugs.webkit.org/show_bug.cgi?id=92453 adds tests for this, but since it may incur some discussions / runaway refactoring, I wanted to separate this part because it's needed soon.
Comment 3 WebKit Review Bot 2012-07-26 23:55:46 PDT
Attachment 154828 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/ChangeLog:9:  Line contains tab character.  [whitespace/tab] [5]
Source/WebCore/ChangeLog:12:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 2 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Stephen White 2012-07-27 09:19:18 PDT
Comment on attachment 154828 [details]
Patch

Looks good (once style bot is happy).  I'll take a look at your other patch on Monday.  r=me
Comment 5 Antoine Labour 2012-07-27 14:28:08 PDT
Created attachment 155048 [details]
Patch for landing
Comment 6 WebKit Review Bot 2012-07-27 16:02:19 PDT
Comment on attachment 155048 [details]
Patch for landing

Clearing flags on attachment: 155048

Committed r123932: <http://trac.webkit.org/changeset/123932>
Comment 7 WebKit Review Bot 2012-07-27 16:02:22 PDT
All reviewed patches have been landed.  Closing bug.