Bug 92450 - nrwt: remove 'webkit.py' and the 'WebKitPort'
Summary: nrwt: remove 'webkit.py' and the 'WebKitPort'
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dirk Pranke
URL:
Keywords: NRWT
Depends on: 92447
Blocks:
  Show dependency treegraph
 
Reported: 2012-07-26 19:35 PDT by Dirk Pranke
Modified: 2012-07-27 14:04 PDT (History)
5 users (show)

See Also:


Attachments
Patch (66.25 KB, patch)
2012-07-26 19:36 PDT, Dirk Pranke
no flags Details | Formatted Diff | Diff
clarify that this is just cut&paste (93.23 KB, patch)
2012-07-26 19:39 PDT, Dirk Pranke
no flags Details | Formatted Diff | Diff
fix base for diff (66.35 KB, patch)
2012-07-26 21:50 PDT, Dirk Pranke
rniwa: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Pranke 2012-07-26 19:35:50 PDT
nrwt: remove 'webkit.py' and the 'WebKitPort'
Comment 1 Dirk Pranke 2012-07-26 19:36:29 PDT
Created attachment 154814 [details]
Patch
Comment 2 Dirk Pranke 2012-07-26 19:39:01 PDT
Created attachment 154817 [details]
clarify that this is just cut&paste
Comment 3 Dirk Pranke 2012-07-26 19:39:30 PDT
adam, eric, ryoksuke - this should make you guys happy :).
Comment 4 Ryosuke Niwa 2012-07-26 20:06:34 PDT
Comment on attachment 154817 [details]
clarify that this is just cut&paste

View in context: https://bugs.webkit.org/attachment.cgi?id=154817&action=review

It seems like you've merged your patch for the bug 92447 here.

> Tools/ChangeLog:86
> +2012-07-26  Dirk Pranke  <dpranke@chromium.org>
> +
> +        nrwt: move image diffing code to a separate module
> +        https://bugs.webkit.org/show_bug.cgi?id=92447

Double entry.
Comment 5 Dirk Pranke 2012-07-26 21:50:39 PDT
Created attachment 154835 [details]
fix base for diff
Comment 6 Dirk Pranke 2012-07-26 21:51:46 PDT
(In reply to comment #4)
> (From update of attachment 154817 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=154817&action=review
> 
> It seems like you've merged your patch for the bug 92447 here.
> 

whoops. I had it right in the first patch but forgot to specify the base for the diff in the second :(. Thanks!
Comment 7 Ryosuke Niwa 2012-07-27 11:31:10 PDT
Comment on attachment 154835 [details]
fix base for diff

View in context: https://bugs.webkit.org/attachment.cgi?id=154835&action=review

This looks right. Please make sure that test-webkitpy & run-webkit-tests run without errors before you land.

> Tools/Scripts/webkitpy/layout_tests/port/base.py:1430
> +    def _skipped_tests_for_unsupported_features(self, test_list):

On my.... This function has waaay too much comment that I can't make sense of the code.
Could you insert some blank lines so that comments and code aren't mangled together?
It's impossible to read as is.

> Tools/Scripts/webkitpy/layout_tests/port/base.py:1459
> +    def _skipped_file_search_paths(self):

Ditto about code & comments completely mangled together.
Comment 8 Dirk Pranke 2012-07-27 11:33:31 PDT
Comment on attachment 154835 [details]
fix base for diff

View in context: https://bugs.webkit.org/attachment.cgi?id=154835&action=review

>> Tools/Scripts/webkitpy/layout_tests/port/base.py:1430
>> +    def _skipped_tests_for_unsupported_features(self, test_list):
> 
> On my.... This function has waaay too much comment that I can't make sense of the code.
> Could you insert some blank lines so that comments and code aren't mangled together?
> It's impossible to read as is.

sure, will do.

>> Tools/Scripts/webkitpy/layout_tests/port/base.py:1459
>> +    def _skipped_file_search_paths(self):
> 
> Ditto about code & comments completely mangled together.

ok.
Comment 9 Dirk Pranke 2012-07-27 14:04:27 PDT
Committed r123916: <http://trac.webkit.org/changeset/123916>