Bug 92450 – nrwt: remove 'webkit.py' and the 'WebKitPort'

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Dirk Pranke]

nrwt: remove 'webkit.py' and the 'WebKitPort'

[Dirk Pranke]

Created attachment 154814 [details]
Patch

[Dirk Pranke]

Created attachment 154817 [details]
clarify that this is just cut&paste

[Dirk Pranke]

adam, eric, ryoksuke - this should make you guys happy :).

[Ryosuke Niwa]

Comment on attachment 154817 [details]
clarify that this is just cut&paste

View in context: https://bugs.webkit.org/attachment.cgi?id=154817&action=review

It seems like you've merged your patch for the bug 92447 here.

> Tools/ChangeLog:86
> [phone]  Dirk Pranke  <[e-mail]>
> +
> +        nrwt: move image diffing code to a separate module
> +        https://bugs.webkit.org/show_bug.cgi?id=92447

Double entry.

[Dirk Pranke]

Created attachment 154835 [details]
fix base for diff

[Dirk Pranke]

(In reply to comment #4)
> (From update of attachment 154817 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=154817&action=review
> 
> It seems like you've merged your patch for the bug 92447 here.
> 

whoops. I had it right in the first patch but forgot to specify the base for the diff in the second :(. Thanks!

[Ryosuke Niwa]

Comment on attachment 154835 [details]
fix base for diff

View in context: https://bugs.webkit.org/attachment.cgi?id=154835&action=review

This looks right. Please make sure that test-webkitpy & run-webkit-tests run without errors before you land.

> Tools/Scripts/webkitpy/layout_tests/port/base.py:1430
> +    def _skipped_tests_for_unsupported_features(self, test_list):

On my.... This function has waaay too much comment that I can't make sense of the code.
Could you insert some blank lines so that comments and code aren't mangled together?
It's impossible to read as is.

> Tools/Scripts/webkitpy/layout_tests/port/base.py:1459
> +    def _skipped_file_search_paths(self):

Ditto about code & comments completely mangled together.

[Dirk Pranke]

Comment on attachment 154835 [details]
fix base for diff

View in context: https://bugs.webkit.org/attachment.cgi?id=154835&action=review

>> Tools/Scripts/webkitpy/layout_tests/port/base.py:1430
>> +    def _skipped_tests_for_unsupported_features(self, test_list):
> 
> On my.... This function has waaay too much comment that I can't make sense of the code.
> Could you insert some blank lines so that comments and code aren't mangled together?
> It's impossible to read as is.

sure, will do.

>> Tools/Scripts/webkitpy/layout_tests/port/base.py:1459
>> +    def _skipped_file_search_paths(self):
> 
> Ditto about code & comments completely mangled together.

ok.

[Dirk Pranke]

Committed r123916: <http://trac.webkit.org/changeset/123916>