Bug 92445 – [Chromium] HarfBuzzShaper can't handle segmented text run

• Status: RESOLVED
• Resolution: FIXED
• Component: Platform

[Kenichi Ishibashi]

The same problem of https://bugs.webkit.org/show_bug.cgi?id=72095 happens when we build chromium with use_harfbuzz_ng=1 GYP flag.

[Kenichi Ishibashi]

Created attachment 154810 [details]
Patch

[Kenichi Ishibashi]

Hi Tony,

Could you take a look?

[Tony Chang]

Comment on attachment 154810 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=154810&action=review

> Source/WebCore/platform/graphics/harfbuzz/ng/HarfBuzzShaper.cpp:194
> +    return index >= m_fromIndex && index < m_toIndex;

Nit: I think "m_fromIndex <= index && index < m_toIndex" is a little easier to read.

> Source/WebCore/platform/graphics/harfbuzz/ng/HarfBuzzShaper.h:100
> +    bool shouldDrawCharacter(int index);

Nit: Maybe name this shouldDrawCharacterAt?

[Kenichi Ishibashi]

Created attachment 155187 [details]
Patch for landing

[Kenichi Ishibashi]

Comment on attachment 154810 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=154810&action=review

Thank you for review!

>> Source/WebCore/platform/graphics/harfbuzz/ng/HarfBuzzShaper.cpp:194
>> +    return index >= m_fromIndex && index < m_toIndex;
> 
> Nit: I think "m_fromIndex <= index && index < m_toIndex" is a little easier to read.

Done.

>> Source/WebCore/platform/graphics/harfbuzz/ng/HarfBuzzShaper.h:100
>> +    bool shouldDrawCharacter(int index);
> 
> Nit: Maybe name this shouldDrawCharacterAt?

Done.

[WebKit Review Bot]

Comment on attachment 155187 [details]
Patch for landing

Clearing flags on attachment: 155187

Committed r123991: <http://trac.webkit.org/changeset/123991>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.