Bug 92420 - Allocate Structures in a separate part of the Heap
Summary: Allocate Structures in a separate part of the Heap
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Hahnenberg
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-07-26 13:39 PDT by Mark Hahnenberg
Modified: 2012-07-26 16:28 PDT (History)
2 users (show)

See Also:


Attachments
Patch (17.28 KB, patch)
2012-07-26 15:28 PDT, Mark Hahnenberg
fpizlo: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Hahnenberg 2012-07-26 13:39:59 PDT
To fix our issue with destruction/finalization of Structures before their objects, we can move Structures to a separate part of the Heap that will be swept after all other objects.
Comment 1 Mark Hahnenberg 2012-07-26 13:40:52 PDT
This first patch will just be separating Structures out into their own separate MarkedAllocator. Everything else will behave identically.
Comment 2 Filip Pizlo 2012-07-26 13:42:51 PDT
(In reply to comment #0)
> To fix our issue with destruction/finalization of Structures before their objects, we can move Structures to a separate part of the Heap that will be swept after all other objects.

I like this approach!  It also enables us to compress structure pointers in various sneaky ways even if we don't do it for all pointers.
Comment 3 Mark Hahnenberg 2012-07-26 15:28:05 PDT
Created attachment 154769 [details]
Patch
Comment 4 Filip Pizlo 2012-07-26 15:30:22 PDT
Comment on attachment 154769 [details]
Patch

seems reasonable
Comment 5 Mark Hahnenberg 2012-07-26 16:28:15 PDT
Committed r123813: <http://trac.webkit.org/changeset/123813>